devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Leonidas P. Papadakos"
	<papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jose Abreu <jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac
Date: Wed, 22 May 2019 20:00:27 -0400	[thread overview]
Message-ID: <8ded737d-1fd5-3609-ca2e-cfeba63b2d95@gmail.com> (raw)
In-Reply-To: <1555938803.1241.1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>



On 4/22/2019 9:13 AM, Leonidas P. Papadakos wrote:
> 
> Indeed, at least with that first patch users won't have a crappy 
> experience by default (ssh lags and the like)
> 
> 

I apologize for taking so long at this, but I wanted to make sure I had 
it right.

So far I've found a few things that seem to help, and would like y'all 
to test them when you get the chance.

Adding snps,aal (configures DMA for address alignment) appears to make a 
massive improvement to stability, although the the snps,txpbl = <0x4> is 
still necessary for this to work.

Second, I added snps,rxpbl = <0x4> as well, which seems to help with my 
RX issues a bit.
The biggest improvement with these two settings is more stable transmit 
and receive.
Currently I'm getting about 800mbps on tx and 400 mbps on rx.

Please test when you get the chance and provide feedback.

  parent reply	other threads:[~2019-05-23  0:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 21:01 [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac Leonidas P. Papadakos
     [not found] ` <20190417210059.26262-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-21 16:00   ` Peter Geis
2019-04-22  6:40     ` Leonidas P. Papadakos
     [not found]     ` <8865b046-fb3a-4071-335c-66abb344d7f4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-22  6:43       ` Leonidas P. Papadakos
     [not found]         ` <1555915435.1262.1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-22 11:57           ` Peter Geis
     [not found]             ` <9a5c62b4-ea75-de4f-9b71-ffa42cb8eaac-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-22 13:13               ` Leonidas P. Papadakos
     [not found]                 ` <1555938803.1241.1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-23  0:00                   ` Peter Geis [this message]
     [not found]                     ` <8ded737d-1fd5-3609-ca2e-cfeba63b2d95-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-14  9:26                       ` Heiko Stuebner
2019-06-15 12:27                         ` Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ded737d-1fd5-3609-ca2e-cfeba63b2d95@gmail.com \
    --to=pgwipeout-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).