From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB89A2571D3 for ; Tue, 25 Mar 2025 13:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742911009; cv=none; b=KBIWKYea65bz+dXOgx9i0RLzTbqtXNYy0ZyEWl7VGEIByg09z6FydlebcNVErRqnMp3h5f5x1fGsfGhnYg6tAxBsILa0JkgXuXk5AuRDjBKD8yDIr3itp4ESGyHKLx7U2C/24xvzb2wNQGhOGh+jFzx1mNAACiJsbwKQ06IcJ9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742911009; c=relaxed/simple; bh=9IaDry6fuUbenQllqTlT5gYi5cOj1Q3ja/I4EJIT8z0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bLCC8fA8dK7WuLEYLwe9nfvlWgZq9+sryVZ/Oe9p2HZMq0IG4dA/oKVz0kZvieJqRBxf24ip0zHDtcaaJsSxTOaxHsFoNmmV5FN0vi5uf94EhHiOmz0VuL7SKPlnZG+Dvyb5KFF2Qe5gu9bNCytSD7wDDZAfSUmRpJlGiyIFY/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bwgfOe93; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bwgfOe93" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52PDNKol024710 for ; Tue, 25 Mar 2025 13:56:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0sLDZktwhqsG1wOZKxLglmBiOdJLLONIkvu2uYKb5xE=; b=bwgfOe93NgXIrhvF iy2HZAAvfKWT42nzdJgEpzmXlWXWSGymuWBRuz1x71ybDi0vo6sYN2C1H1su3imx BuQfU1UOemDBpZ5YbLCBT3aQmaSF3yxook1e/SnKD4ek5vgiJwaSuElQ5DYyYK+f DFG3OnMesGr/CYRFxqTo+lKbfuteauAb6Crv+r9YP/YVZGWkf6n7W58RYVSuBqwB 4viRSJhtD6wp7hqFBcu9QFMhIPw9j7fVRc7aVyDVHt4zR9aRz9TzJpuFuLvMq4EO WR+zx4HbyztXPMB6ZVYYJnM8T8tDU2d6o71QVgO+8uLlRM7OQ7zJCE8zv/1JvEu1 c97pLg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45k7qjbr1e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 13:56:46 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4775bdbcdc3so363441cf.2 for ; Tue, 25 Mar 2025 06:56:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742911005; x=1743515805; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0sLDZktwhqsG1wOZKxLglmBiOdJLLONIkvu2uYKb5xE=; b=c9mc0b20kB7mNjgm2k/JAS7Ku2dQ7/kat2HzPXINP/P778PhWDP+3zBahr8C56K0kw m405bTt+uG+lg0V/JqfurJxr+f4vmCIw235E+1xphwQI6Xt2YeIwv06d5KI9kB2e8sSJ htUCAJFLju0tbO/udvwHlDAgGz1VQFqy74lhXR2inDoYtoF+qoViULAYQ2bk3+hnm3hV dYlwZA9OgxvygT/RdzJoyQCCoBb2avGN3BduPN6PE8HO54ikjiw0cULCN0OjCjmZyg2P T41cC18KSyiTsyv9B1BSXVWovXR/q8Q3ieP9XVlqBSSMd4/PGIYiwNPDA4bwuGgYpvHF jxAA== X-Forwarded-Encrypted: i=1; AJvYcCXy2SIIFV+9e6c87ZaIDRH83FyptNyJCnDkltFE6oZWsXyzFxwyq9niOgAeJb3Sb+UTW02WPwqYh33E@vger.kernel.org X-Gm-Message-State: AOJu0Yw6wNSZjHVK7JDycP8e4hl8hFdf66z3j9p9q7tbXjA7p4GYyVgC 9zjUHOfJ++kL47c7As4GSkoeCitidncXS1F2BhS1ZIezYs88Q+x5M/IsKUJfBhAOMWC+Lv4mHcd pcLqXBuqyU6+ieXjpPHq4PplmlJyrZrqWXganOu3Coaa8BYnz9OyPWN75mP9/ X-Gm-Gg: ASbGncspHMMzxta3phfk00bg1oLwA3JsjeLAV+Uveu9mEL1U3r+QIlGjukbvZnrC9Zd +DBQeZGiDdYca4nMTMVCjprICVN8uAIgOg/FRco4RHyPvwwxLECe4IzWEatcYF2kCaEhIQGF7u0 BRtirJc9uozrExoXjajQ2J87cg3ZkK1kRE6apuTRlbLFd8NvKPfeDqLTLambWQnQpx/YzrumUCk J+563J3b5BsAgnqcKKdQc1CXJ/7LGo4Y/S1X1KmFmMHqLnf12ght/ZRoUuuXss6gxSasz/iXitp ofMxEb8+LSYNkXRIi0z2roB0ZKaZtTnqPNXuFIIfluDy/5EW3Pk5pbjBjGyeYjkc5QQCGg== X-Received: by 2002:a05:622a:1883:b0:473:884e:dcff with SMTP id d75a77b69052e-4771de13f51mr88067261cf.13.1742911005331; Tue, 25 Mar 2025 06:56:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn+bjrW3qy1jJkHXha130pv0V5DkYmNYCdBX0USZFkxoEZBO3/5NEu0ewfyB/epISxwClUwg== X-Received: by 2002:a05:622a:1883:b0:473:884e:dcff with SMTP id d75a77b69052e-4771de13f51mr88067141cf.13.1742911004890; Tue, 25 Mar 2025 06:56:44 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebccf665dcsm7788319a12.13.2025.03.25.06.56.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 06:56:44 -0700 (PDT) Message-ID: <8e301a7b-c475-4642-bf91-7a5176a00d1f@oss.qualcomm.com> Date: Tue, 25 Mar 2025 14:56:40 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x PCIe switch To: Krzysztof Kozlowski , Krishna Chaitanya Chundru Cc: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , chaitanya chundru , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicnic.com, amitk@kernel.org, dmitry.baryshkov@linaro.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, jorge.ramirez@oss.qualcomm.com References: <20250225-qps615_v4_1-v4-0-e08633a7bdf8@oss.qualcomm.com> <20250225-qps615_v4_1-v4-1-e08633a7bdf8@oss.qualcomm.com> <20250226-eager-urchin-of-performance-b71ae4@krzk-bin> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250226-eager-urchin-of-performance-b71ae4@krzk-bin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 5k0M-78VYDzw0PnNRK6WnevrEjg6dfOh X-Proofpoint-GUID: 5k0M-78VYDzw0PnNRK6WnevrEjg6dfOh X-Authority-Analysis: v=2.4 cv=feOty1QF c=1 sm=1 tr=0 ts=67e2b61e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gGbnW7COpTo7U3-rSK8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_06,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250098 On 2/26/25 8:30 AM, Krzysztof Kozlowski wrote: > On Tue, Feb 25, 2025 at 03:03:58PM +0530, Krishna Chaitanya Chundru wrote: >> From: Krishna chaitanya chundru >> >> Add a device tree binding for the Toshiba TC956x PCIe switch, which >> provides an Ethernet MAC integrated to the 3rd downstream port and two >> downstream PCIe ports. >> >> Signed-off-by: Krishna chaitanya chundru >> Reviewed-by: Bjorn Andersson > > Drop, file was named entirely different. I see other changes, altough > comparing with b4 is impossible. > > Why b4 does not work for this patch? > > b4 diff '20250225-qps615_v4_1-v4-1-e08633a7bdf8@oss.qualcomm.com' > Checking for older revisions > Grabbing search results from lore.kernel.org > Nothing matching that query. > > Looks like you use b4 but decide to not use b4 changesets/versions. Why > making it difficult for reviewers and for yourself? > > >> --- >> .../devicetree/bindings/pci/toshiba,tc956x.yaml | 178 +++++++++++++++++++++ >> 1 file changed, 178 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml >> new file mode 100644 >> index 000000000000..ffed23004f0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc956x.yaml > > What is "x" here? Wildcard? Yes, an overly broad one. Let's use the actual name going forward. Konrad