From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: cezary.rojewski@intel.com, broonie@kernel.org,
lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, perex@perex.cz, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
flove@realtek.com, shumingf@realtek.com, jack.yu@realtek.com,
derek.fang@realtek.com
Subject: Re: [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575
Date: Fri, 5 Dec 2025 09:31:52 +0100 [thread overview]
Message-ID: <8e537cb4-08a0-4ecb-90f5-01ff2d4b32f8@kernel.org> (raw)
In-Reply-To: <20251205-stylish-numbat-of-awe-10edcd@quoll>
On 05/12/2025 09:31, Krzysztof Kozlowski wrote:
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>
> You listed so many "impressive" and "rich" features that for sure this
> is incomplete.
>
> Please post complete bindings for "impressive" device.
>
> You miss supplies, you miss all the AI related hype (no clue what that
> would be, but for sure NPU feels like needing remoteproc or at least
> some other way to communicate). We all know that AI is power hungry, so
> it is impossible to run it without electricity (thus supplies).
>
Also two standard nits, in case I did not ask about them before:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-05 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:59 [PATCH v8 0/2] ASoC: rt5575: Add the codec driver for the ALC5575 Oder Chiou
2025-12-01 10:59 ` [PATCH v8 1/2] " Oder Chiou
2025-12-08 6:05 ` Krzysztof Kozlowski
2025-12-08 7:29 ` Oder Chiou
2025-12-08 8:01 ` Krzysztof Kozlowski
2025-12-08 9:16 ` Oder Chiou
2025-12-09 6:07 ` Krzysztof Kozlowski
2025-12-10 5:26 ` Oder Chiou
2025-12-10 9:14 ` Cezary Rojewski
2025-12-08 20:05 ` Cezary Rojewski
2025-12-09 5:35 ` Oder Chiou
2025-12-10 9:22 ` Cezary Rojewski
2025-12-01 10:59 ` [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575 Oder Chiou
2025-12-05 8:31 ` Krzysztof Kozlowski
2025-12-05 8:31 ` Krzysztof Kozlowski [this message]
2025-12-08 5:55 ` Oder Chiou
2025-12-08 5:55 ` Oder Chiou
2025-12-08 6:02 ` Krzysztof Kozlowski
2025-12-08 6:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e537cb4-08a0-4ecb-90f5-01ff2d4b32f8@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).