* [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node
@ 2025-02-17 5:27 niravkumar.l.rabara
2025-02-17 9:08 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: niravkumar.l.rabara @ 2025-02-17 5:27 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
niravkumar.l.rabara, nirav.rabara, devicetree, linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Add GPIO led and memory node for Agilex5 devkit.
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
.../boot/dts/intel/socfpga_agilex5_socdk.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
index c533e5a3a610..59530eada2ea 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
@@ -15,6 +15,25 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+ leds {
+ compatible = "gpio-leds";
+
+ led1 {
+ label = "hps_led1";
+ gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
+ };
+
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ /* We expect the bootloader to fill in the reg */
+ reg = <0x0 0x80000000 0x0 0x0>;
+ };
+};
+
+&gpio0 {
+ status = "okay";
};
&gpio1 {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node
2025-02-17 5:27 [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node niravkumar.l.rabara
@ 2025-02-17 9:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-17 9:08 UTC (permalink / raw)
To: niravkumar.l.rabara, Dinh Nguyen, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, nirav.rabara, devicetree,
linux-kernel
On 17/02/2025 06:27, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Add GPIO led and memory node for Agilex5 devkit.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
> .../boot/dts/intel/socfpga_agilex5_socdk.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index c533e5a3a610..59530eada2ea 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -15,6 +15,25 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
Missing blank line
> + leds {
> + compatible = "gpio-leds";
> +
> + led1 {
led-0
> + label = "hps_led1";
> + gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
> + };
> +
And that's not necessary
> + };
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-17 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 5:27 [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node niravkumar.l.rabara
2025-02-17 9:08 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).