From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04328C83F18 for ; Tue, 29 Aug 2023 18:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238096AbjH2Si4 (ORCPT ); Tue, 29 Aug 2023 14:38:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238281AbjH2Sim (ORCPT ); Tue, 29 Aug 2023 14:38:42 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B935C1A3; Tue, 29 Aug 2023 11:38:39 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C669932005BC; Tue, 29 Aug 2023 14:38:36 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 29 Aug 2023 14:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1693334316; x=1693420716; bh=CAWsIypx0TY0UMQV9vU8AQzRqsAv1DpcyRv Hl2mMQgE=; b=HsjvMByVL1iz7yHe0DjJP45B5iT/tMpAYlpQJW6a4qlguMc1JMg 42/dIFNb+bC2vHH8mIIjWqZWS+y7q6NGbTzyEkE+tofqvlTDk1SfK3+xCFuvOD07 acYYpQNkv1S8jQAssRO63+1iBXRTVoqZwAebNUPMmAVAArkzs0Z8KA00RzpDxj2I nx3GvZZUFQcRVNjfM/egQR+DOaaVVXx0T4W07W4bBBPC7aw+6RNTslmJtF2QVpM+ vjFyPZqzbiAUaI5pcPVck/8p79249lMlWq0xYBIeyDjROfYFEXm5Q5izXlTdXjcc DUQ6cSJ8x85dxxE7W28AWpolXqHyF7vDN9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693334316; x=1693420716; bh=CAWsIypx0TY0UMQV9vU8AQzRqsAv1DpcyRv Hl2mMQgE=; b=H5xDt7imC/5eWQgMkyYCerYVVivMTwQxYF1FaPcCiYZhCCAu5MP 4cb0jBvaPc0ztXQ2eBEeFo3rOc5mTcr6eKwpdmxGrd6f+rn9Rfj0xddR9QVoTmlC AHOaaKOZZ+LsWa2jyFy1Vd8tHidXUrZNShudk0poBXUyCimq1NKmXc7iQjS7BduO DKhli5Yq/nGJMmrxaAOJhvw76R/M4bQ2nQf+oaBDgZXe351yilECye/JkPWgYcmL URAIGVamP8Xorw3cPKaLdmhLrxZufxPkpUj3p5k+21tEXq40QVu4xk+kr8r31yt0 2xLsgwBul5/oA2dDMYmgLLDvaVgB4IUwTzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefiedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4108EB60089; Tue, 29 Aug 2023 14:38:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-701-g9b2f44d3ee-fm-20230823.001-g9b2f44d3 Mime-Version: 1.0 Message-Id: <8e87875b-5be1-4d82-bcbf-bd6c8d36370f@app.fastmail.com> In-Reply-To: References: <20230810093322.593259-1-mitrutzceclan@gmail.com> <20230810093322.593259-2-mitrutzceclan@gmail.com> <34f5e2118a4714048231e6ee9a8f244248616bd0.camel@gmail.com> <5a31871d0e0322b9704633bd2dca2503c554c358.camel@gmail.com> Date: Tue, 29 Aug 2023 14:38:03 -0400 From: "Arnd Bergmann" To: "Andy Shevchenko" , =?UTF-8?Q?Nuno_S=C3=A1?= , "Linus Walleij" , "Bartosz Golaszewski" Cc: "Dumitru Ceclan" , "Lars-Peter Clausen" , "Michael Hennerich" , "Jonathan Cameron" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Cosmin Tanislav" , "Alexander Sverdlin" , "Hugo Villeneuve" , "Okan Sahin" , "Niklas Schnelle" , "ChiYuan Huang" , "Ramona Bolboaca" , "Ibrahim Tilki" , "ChiaEn Wu" , "William Breathitt Gray" , "Lee Jones" , "Haibo Chen" , "Mike Looijmans" , =?UTF-8?Q?Leonard_G=C3=B6hrs?= , "Ceclan Dumitru" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iio: adc: ad717x: add AD717X driver Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 29, 2023, at 09:31, Andy Shevchenko wrote: > On Tue, Aug 29, 2023 at 11:14:31AM +0200, Nuno S=C3=A1 wrote: >> On Thu, 2023-08-10 at 18:36 +0300, Andy Shevchenko wrote: >> > On Thu, Aug 10, 2023 at 01:57:02PM +0200, Nuno S=C3=A1 wrote: >> > > On Thu, 2023-08-10 at 12:33 +0300, Dumitru Ceclan wrote: > >> > > Is ad717x_gpio_cleanup() being used anywhere? Moreover I would ma= ybe just >> > > get rid of >> > > the #ifdef wrapper and just select GPIOLIB. How often will it be = disabled >> > > anyways? >> >=20 >> > The agreement is that users are depend on and not selecting GPIOLIB. >> > Any news in these agreement terms? >>=20 >> Hmm no idea about that. If you say so, it's just one new thing I'm le= arning :) >Based outside of the U.S.? Some titles might be unavailable in your cur= rent location. Go to amazon.de to see the video catalog available in Ger= many. > That's the last I know. > Cc'ing to GPIOLIB maintainers... >From a Kconfig perspective, any user-visible symbol ideally only uses 'depends on', while hidden symbols usually use 'select'. For the GPIOLIB symbol specifically, we have a mix of both, but the overall usage is that gpio consumers only use 'depends on', while some of the providers use 'select'. This risks causing build breakage from a dependency loop when combined with other symbols that have the same problem (e.g. I2C), but it tends to work out as long as a strong hierarchy is kept. In particular, using 'select' from an arch/*/Kconfig platform option is generally harmless as long as those don't depend on anything else. The new driver is a gpio provider and at least ad4130 and ad5592r uses 'select' here, but then again ad74115 and ad74113 use 'depends on' and ads7950 uses neither. I think the best way to handle these is to remove both the 'select' and the #ifdef in the driver and instead use 'if (IS_ENABLED(CONFIG_GPIOLIB))' to handle optional gpio providers in the code. Arnd