From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasanthakumar Thiagarajan Subject: Re: [PATCH 31/49] ath11k: add mac.c Date: Thu, 05 Sep 2019 17:28:53 +0530 Message-ID: <8e90a557c1659995d117c6dc8b728d7f@codeaurora.org> References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-32-git-send-email-kvalo@codeaurora.org> <4076919b34cad119eb4146025f587285ef40e37c.camel@sipsolutions.net> <878sr3nfz8.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <878sr3nfz8.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kalle Valo Cc: Johannes Berg , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ath11k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 2019-09-05 16:54, Kalle Valo wrote: > Vasanthakumar Thiagarajan writes: > >> On 2019-08-21 02:16, Johannes Berg wrote: >>> On Tue, 2019-08-20 at 18:47 +0300, Kalle Valo wrote: >>> >>>> +static int ath11k_mac_op_config(struct ieee80211_hw *hw, u32 >>>> changed) >>>> +{ >>>> + struct ath11k *ar = hw->priv; >>>> + int ret = 0; >>>> + >>>> + /* mac80211 requires this op to be present and that's why >>>> + * there's an empty function, this can be extended when >>>> + * required. >>>> + */ >>> >>> Well, oops. Maybe it shouldn't be required? >> >> I think we require this for some configuration handling. The comment >> is to be updated with proper information. We'll address that. > > The way I'm understanding Johannes' comment is that maybe we should > change mac80211 to require this op to be present. Should be easy to fix > in mac80211, right? Ok. So make this callback optional in mac80211? should be a simple code change. Vasanth