From mboxrd@z Thu Jan 1 00:00:00 1970 From: m18063 Subject: Re: [PATCH v2 5/6] pwm: mediatek: add PWM_CLK_DIV_MAX Date: Mon, 26 Jun 2017 11:43:01 +0300 Message-ID: <8eaabcb6-c7b1-efcc-7dae-967a38feb8f1@microchip.com> References: <1498194505-30930-1-git-send-email-zhi.mao@mediatek.com> <1498194505-30930-6-git-send-email-zhi.mao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1498194505-30930-6-git-send-email-zhi.mao@mediatek.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Zhi Mao , john@phrozen.org, Thierry Reding , Rob Herring , Mark Rutland , Matthias Brugger , linux-pwm@vger.kernel.org Cc: zhenbao.liu@mediatek.com, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, yt.shen@mediatek.com, yingjoe.chen@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 23.06.2017 08:08, Zhi Mao wrote: > Replace "7" with "PWM_CLK_DIV_MAX" in function:mtk_pwm_config() > to improve the code readablity. > > Signed-off-by: Zhi Mao > --- > drivers/pwm/pwm-mediatek.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index 554a042..e5f6425 100644 > --- a/drivers/pwm/pwm-mediatek.c > +++ b/drivers/pwm/pwm-mediatek.c > @@ -30,6 +30,8 @@ > #define PWMDWIDTH 0x2c > #define PWMTHRES 0x30 > > +#define PWM_CLK_DIV_MAX 7 > + > enum { > MTK_CLK_MAIN = 0, > MTK_CLK_TOP, > @@ -130,8 +132,10 @@ static int mtk_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > clkdiv++; > } > > - if (clkdiv > 7) > + if (clkdiv > PWM_CLK_DIV_MAX) { You forgot to: mtk_pwm_clk_disable(chip, pwm); > + dev_err(chip->dev, "period %d not supported\n", period_ns); > return -EINVAL; > + } > > mtk_pwm_writel(pc, pwm->hwpwm, PWMCON, BIT(15) | clkdiv); > mtk_pwm_writel(pc, pwm->hwpwm, PWMDWIDTH, period_ns / resolution); >