From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: add 16 ratio of pre-scaling
Date: Sun, 16 Apr 2023 16:17:10 +0200 [thread overview]
Message-ID: <8eb3e8e5-95a8-ffcd-aa09-8d6d63b7f526@linaro.org> (raw)
In-Reply-To: <20230416141024.2c09d7c8@jic23-huawei>
On 16/04/2023 15:10, Jonathan Cameron wrote:
> On Sun, 16 Apr 2023 14:31:42 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> Document value of 16 for pre-scaling, already used in DTS and supported
>> by the Linux driver since long time:
>>
>> sm7225-fairphone-fp4.dtb: adc@3100: channel@8:qcom,pre-scaling: 'oneOf' conditional failed, one must be fixed:
>> 10 was expected
>> 16 is not one of [1, 3, 4, 6, 20, 8, 10]
>> 81 was expected
>>
>> Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> I'm carrying an identical patch (though without the reordering) from Luca Weiss.
> I thought as the whole series was very late in the cycle that it was unlikely
> to be necessary to rush this in.
>
> https://lore.kernel.org/all/20230414-pmi632-v1-5-fe94dc414832@z3ntu.xyz/
>
> I see that patch is for the fairphone-fp3 adn this report is the fairphone-fp4.
> Is that the reason this is a fix?
Oh, I missed it. It's just something new and not yet in next maybe, so
thus I missed the fix.
Ignore this patch then, please.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-04-16 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 12:31 [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: add 16 ratio of pre-scaling Krzysztof Kozlowski
2023-04-16 13:10 ` Jonathan Cameron
2023-04-16 14:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb3e8e5-95a8-ffcd-aa09-8d6d63b7f526@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox