From: Johan Jonker <jbx6244@gmail.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, kishon@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: rockchip: convert rockchip-dp-phy.txt to yaml
Date: Fri, 13 Jan 2023 20:58:30 +0100 [thread overview]
Message-ID: <8eca0d59-8db3-b66e-f219-0a256a9b0c79@gmail.com> (raw)
In-Reply-To: <Y8GeBzNJvhMeh3sn@matsya>
On 1/13/23 19:08, Vinod Koul wrote:
> On 29-12-22, 10:44, Johan Jonker wrote:
>> Convert rockchip-dp-phy.txt to yaml.
>
> This series fails to apply, pls rebase
Hi Vinod, Heiko,
This serie and others must be combined in the right order to grf.yaml.
Maybe better that Heiko does that with your ACK.
Johan
===
Apply after:
dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml
>>
>> Changed:
>> rename file name
>
> This should not be in change log but after the --- line
>
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>>
>> Changed V2:
>> Use the compatible as filename.
>> ---
>> .../bindings/phy/rockchip,rk3288-dp-phy.yaml | 41 +++++++++++++++++++
>> .../bindings/phy/rockchip-dp-phy.txt | 26 ------------
>> 2 files changed, 41 insertions(+), 26 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3288-dp-phy.yaml
>> delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3288-dp-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3288-dp-phy.yaml
>> new file mode 100644
>> index 000000000..2538235c5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3288-dp-phy.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/rockchip,rk3288-dp-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip specific extensions to the Analogix Display Port PHY
>> +
>> +maintainers:
>> + - Heiko Stuebner <heiko@sntech.de>
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,rk3288-dp-phy
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: 24m
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> +required:
>> + - compatible
>> + - clocks
>> + - clock-names
>> + - "#phy-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/rk3288-cru.h>
>> + edp-phy {
>> + compatible = "rockchip,rk3288-dp-phy";
>> + clocks = <&cru SCLK_EDP_24M>;
>> + clock-names = "24m";
>> + #phy-cells = <0>;
>> + };
>> diff --git a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>> deleted file mode 100644
>> index e3b4809fb..000000000
>> --- a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>> +++ /dev/null
>> @@ -1,26 +0,0 @@
>> -Rockchip specific extensions to the Analogix Display Port PHY
>> -------------------------------------
>> -
>> -Required properties:
>> -- compatible : should be one of the following supported values:
>> - - "rockchip.rk3288-dp-phy"
>> -- clocks: from common clock binding: handle to dp clock.
>> - of memory mapped region.
>> -- clock-names: from common clock binding:
>> - Required elements: "24m"
>> -- #phy-cells : from the generic PHY bindings, must be 0;
>> -
>> -Example:
>> -
>> -grf: syscon@ff770000 {
>> - compatible = "rockchip,rk3288-grf", "syscon", "simple-mfd";
>> -
>> -...
>> -
>> - edp_phy: edp-phy {
>> - compatible = "rockchip,rk3288-dp-phy";
>> - clocks = <&cru SCLK_EDP_24M>;
>> - clock-names = "24m";
>> - #phy-cells = <0>;
>> - };
>> -};
>> --
>> 2.20.1
>
next prev parent reply other threads:[~2023-01-13 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 9:44 [PATCH v2 1/2] dt-bindings: phy: rockchip: convert rockchip-dp-phy.txt to yaml Johan Jonker
2022-12-29 9:45 ` [PATCH v2 2/2] dt-bindings: soc: rockchip: grf: add rockchip,rk3288-dp-phy.yaml Johan Jonker
2022-12-29 10:30 ` [PATCH v2 1/2] dt-bindings: phy: rockchip: convert rockchip-dp-phy.txt to yaml Krzysztof Kozlowski
2023-01-13 18:08 ` Vinod Koul
2023-01-13 19:58 ` Johan Jonker [this message]
2023-01-18 17:01 ` Vinod Koul
2023-01-29 13:39 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eca0d59-8db3-b66e-f219-0a256a9b0c79@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).