From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] soc: qcom: mdt_loader: Support Qualcomm SM8450
Date: Thu, 3 Feb 2022 18:11:49 +0300 [thread overview]
Message-ID: <8ee1cea3-00f3-7a9c-dbd9-aaf8160db006@linaro.org> (raw)
In-Reply-To: <20220128025513.97188-1-bjorn.andersson@linaro.org>
On 28/01/2022 05:55, Bjorn Andersson wrote:
> The Qualcomm SM8450 platform comes with both some smaller changes in the
> firmware packaging and a new requirement to hold onto the metadata buffer until
> PAS auth_and_reset has been completed.
>
> Extend the PAS api and rework the mdt_loader to meet these new requirements,
> then wire this up with the PAS remoteproc driver and finally add the SM8450
> remoteproc instances.
>
> Bjorn Andersson (13):
> firmware: qcom: scm: Introduce pas_metadata context
> soc: qcom: mdt_loader: Split out split-file-loader
> soc: qcom: mdt_loader: Allow hash segment to be split out
> soc: qcom: mdt_loader: Allow hash to reside in any segment
> soc: qcom: mdt_loader: Extend check for split firmware
> soc: qcom: mdt_loader: Reorder parts of __qcom_mdt_load()
> soc: qcom: mdt_loader: Always invoke PAS mem_setup
> soc: qcom: mdt_loader: Extract PAS operations
> remoteproc: qcom: pas: Carry PAS metadata context
> dt-bindings: remoteproc: qcom: pas: Add SM8450 PAS compatibles
> remoteproc: qcom: pas: Add SM8450 remoteproc support
> arm64: dts: qcom: sm8450: Add remoteproc enablers and instances
> arm64: dts: qcom: sm8450-qrd: Enable remoteproc instances
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Minor nitpicks:
- I'd reorder the series by moving patch 1 (pas_metadata) closer to
patch 8&9 (pas metadata usage)
- I would have added pas_metadata as an argument to qcom_mdt_load().
However I see, why you didn't want to add another argument to the list.
>
> .../bindings/remoteproc/qcom,adsp.yaml | 16 +
> arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 20 ++
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 297 ++++++++++++++++++
> drivers/firmware/qcom_scm.c | 39 ++-
> drivers/remoteproc/qcom_q6v5_mss.c | 7 +-
> drivers/remoteproc/qcom_q6v5_pas.c | 36 ++-
> drivers/soc/qcom/mdt_loader.c | 232 +++++++++-----
> include/linux/qcom_scm.h | 10 +-
> include/linux/soc/qcom/mdt_loader.h | 17 +-
> 9 files changed, 579 insertions(+), 95 deletions(-)
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-02-03 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 2:55 [PATCH 00/13] soc: qcom: mdt_loader: Support Qualcomm SM8450 Bjorn Andersson
2022-01-28 2:55 ` [PATCH 01/13] firmware: qcom: scm: Introduce pas_metadata context Bjorn Andersson
2023-05-24 11:17 ` Robert Marko
2022-01-28 2:55 ` [PATCH 02/13] soc: qcom: mdt_loader: Split out split-file-loader Bjorn Andersson
2022-01-28 2:55 ` [PATCH 03/13] soc: qcom: mdt_loader: Allow hash segment to be split out Bjorn Andersson
2022-01-28 2:55 ` [PATCH 04/13] soc: qcom: mdt_loader: Allow hash to reside in any segment Bjorn Andersson
2022-01-28 2:55 ` [PATCH 05/13] soc: qcom: mdt_loader: Extend check for split firmware Bjorn Andersson
2022-01-28 2:55 ` [PATCH 06/13] soc: qcom: mdt_loader: Reorder parts of __qcom_mdt_load() Bjorn Andersson
2022-01-28 2:55 ` [PATCH 07/13] soc: qcom: mdt_loader: Always invoke PAS mem_setup Bjorn Andersson
2022-01-28 2:55 ` [PATCH 08/13] soc: qcom: mdt_loader: Extract PAS operations Bjorn Andersson
2022-01-28 2:55 ` [PATCH 09/13] remoteproc: qcom: pas: Carry PAS metadata context Bjorn Andersson
2022-01-28 2:55 ` [PATCH 10/13] dt-bindings: remoteproc: qcom: pas: Add SM8450 PAS compatibles Bjorn Andersson
2022-01-28 2:55 ` [PATCH 11/13] remoteproc: qcom: pas: Add SM8450 remoteproc support Bjorn Andersson
2022-01-28 2:55 ` [PATCH 12/13] arm64: dts: qcom: sm8450: Add remoteproc enablers and instances Bjorn Andersson
2022-02-28 8:13 ` Dmitry Baryshkov
2022-01-28 2:55 ` [PATCH 13/13] arm64: dts: qcom: sm8450-qrd: Enable remoteproc instances Bjorn Andersson
2022-02-03 15:11 ` Dmitry Baryshkov [this message]
2022-02-03 18:20 ` [PATCH 00/13] soc: qcom: mdt_loader: Support Qualcomm SM8450 Bjorn Andersson
2022-02-04 18:35 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee1cea3-00f3-7a9c-dbd9-aaf8160db006@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).