From: Krzysztof Kozlowski <krzk@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: ti,pcm512x: Convert to dtschema
Date: Wed, 17 Jul 2024 14:10:34 +0200 [thread overview]
Message-ID: <8eeaaffe-6c18-4449-a272-ca34a88fc731@kernel.org> (raw)
In-Reply-To: <20240717071012.114786-1-animeshagarwal28@gmail.com>
On 17/07/2024 09:10, Animesh Agarwal wrote:
> Convert the PCM512x and TAS575x audio CODECs/amplifiers bindings to DT
> schema format. Add missing sound-dai-cells property.
>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
> +
> +required:
> + - compatible
> + - reg
> + - AVDD-supply
> + - DVDD-supply
> + - CPVDD-supply
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas5754
> + - ti,tas5756
> +
> +then:
> + properties:
> + pll-in:
Please define properties in top-level properties list, not in
conditional. You can narrow the constraints per variant in conditional.
> + description: GPIO pin used to connect the pll using <1> through <3>. The
> + device will be configured for clock input on the given pll-in pin.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 1
> + maximum: 3
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-17 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 7:10 [PATCH] ASoC: dt-bindings: ti,pcm512x: Convert to dtschema Animesh Agarwal
2024-07-17 12:10 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eeaaffe-6c18-4449-a272-ca34a88fc731@kernel.org \
--to=krzk@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).