[PATCH v2 1/2] arm64: dts: imx93: Add the TMU interrupt

[PATCH v2 1/2] arm64: dts: imx93: Add the TMU interrupt

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

The Thermal Monitoring Unit (TMU) interrupt is number 83.

Describe it in the devicetree to fix the following schema warning:

imx93-11x11-evk.dtb: tmu@44482000: 'oneOf' conditional failed, one must be fixed:
	'interrupts' is a required property
	'interrupts-extended' is a required property
	from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- None

 arch/arm64/boot/dts/freescale/imx93.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 6f85a05ee7e1..5d36b7a5bbd5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -385,6 +385,7 @@ anatop: anatop@44480000 {
 			tmu: tmu@44482000 {
 				compatible = "fsl,qoriq-tmu";
 				reg = <0x44482000 0x1000>;
+				interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_TMC_GATE>;
 				little-endian;
 				fsl,tmu-range = <0x800000da 0x800000e9
-- 
2.34.1

[PATCH v2 2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

imx93 has a maximum of seven entries for fsl,tmu-range.

Change it accordingly.

This fixes the following schema warning:

imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed:
	[2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reduce the context of the schema warning in the commit log.

 Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
index 145744027234..d3734fc66f78 100644
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
@@ -33,7 +33,8 @@ properties:
     description: |
       The values to be programmed into TTRnCR, as specified by the SoC
       reference manual. The first cell is TTR0CR, the second is TTR1CR, etc.
-    maxItems: 4
+    minItems: 4
+    maxItems: 7
 
   fsl,tmu-calibration:
     $ref: /schemas/types.yaml#/definitions/uint32-matrix
-- 
2.34.1

Re: [PATCH v2 2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems

[Krzysztof Kozlowski]

On 10/09/2023 14:57, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> imx93 has a maximum of seven entries for fsl,tmu-range.
> 

Then qoriq should have it constrained to 4 entries.

Best regards,
Krzysztof

Re: [PATCH v2 2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems

[Fabio Estevam]

Hi Krzysztof,

On Mon, Sep 11, 2023 at 3:14 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/09/2023 14:57, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > imx93 has a maximum of seven entries for fsl,tmu-range.
> >
>
> Then qoriq should have it constrained to 4 entries.

I just noticed that fsl-lx2160a.dtsi is also has a tmu compatible with
two entries.

Would it be OK to represent it like this?

--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
@@ -33,7 +33,8 @@ properties:
     description: |
       The values to be programmed into TTRnCR, as specified by the SoC
       reference manual. The first cell is TTR0CR, the second is TTR1CR, etc.
-    maxItems: 4
+    minItems: 2
+    maxItems: 7

Re: [PATCH v2 1/2] arm64: dts: imx93: Add the TMU interrupt

[Shawn Guo]

On Sun, Sep 10, 2023 at 09:57:25AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The Thermal Monitoring Unit (TMU) interrupt is number 83.
> 
> Describe it in the devicetree to fix the following schema warning:
> 
> imx93-11x11-evk.dtb: tmu@44482000: 'oneOf' conditional failed, one must be fixed:
> 	'interrupts' is a required property
> 	'interrupts-extended' is a required property
> 	from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!