From: Marc Zyngier <maz@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: kernel test robot <lkp@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
kbuild-all@lists.01.org,
Valentin Schneider <valentin.schneider@arm.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Maulik Shah <quic_mkshah@quicinc.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] irqchip: Add Qualcomm MPM controller driver
Date: Fri, 25 Feb 2022 08:54:10 +0000 [thread overview]
Message-ID: <8eff0caf8a8a10f0e8bf99bc9f949c5d@kernel.org> (raw)
In-Reply-To: <20220224021017.GA269879@dragon>
On 2022-02-24 02:10, Shawn Guo wrote:
> On Thu, Feb 24, 2022 at 07:43:21AM +0800, kernel test robot wrote:
>> Hi Shawn,
>>
>> I love your patch! Perhaps something to improve:
>>
>> [auto build test WARNING on tip/irq/core]
>> [also build test WARNING on robh/for-next linus/master v5.17-rc5
>> next-20220222]
>> [If your patch is applied to the wrong git tree, kindly drop us a
>> note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/Shawn-Guo/Add-Qualcomm-MPM-irqchip-driver-support/20220223-210123
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>> d2206fcabdfaff3958ab67cc5b8f63257e57b889
>> config: arm64-allyesconfig
>> (https://download.01.org/0day-ci/archive/20220224/202202240730.8ES2LbM6-lkp@intel.com/config)
>> compiler: aarch64-linux-gcc (GCC) 11.2.0
>> reproduce (this is a W=1 build):
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> #
>> https://github.com/0day-ci/linux/commit/17f8a23f57bf6d0177f6ef6f78237b37bd853e8d
>> git remote add linux-review https://github.com/0day-ci/linux
>> git fetch --no-tags linux-review
>> Shawn-Guo/Add-Qualcomm-MPM-irqchip-driver-support/20220223-210123
>> git checkout 17f8a23f57bf6d0177f6ef6f78237b37bd853e8d
>> # save the config file to linux build tree
>> mkdir build_dir
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0
>> make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/irqchip/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>> >> drivers/irqchip/qcom-mpm.c:210:21: warning: no previous prototype for 'get_mpm_gic_map' [-Wmissing-prototypes]
>> 210 | struct mpm_gic_map *get_mpm_gic_map(struct qcom_mpm_priv
>> *priv, int pin)
>> | ^~~~~~~~~~~~~~~
>
> Oops! The 'static' declaration got lost. Will fix in the next
> version.
While you're at it, please rename this driver to irq-qcom-mpm.c
in order to match the rest of the drivers. I have no idea
why the QC stuff is named differently...
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2022-02-25 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 12:55 [PATCH v6 0/3] Add Qualcomm MPM irqchip driver support Shawn Guo
2022-02-23 12:55 ` [PATCH v6 1/3] PM: cpu: Add CPU_LAST_PM_ENTER and CPU_FIRST_PM_EXIT support Shawn Guo
2022-02-23 19:30 ` Sudeep Holla
2022-02-25 4:33 ` Shawn Guo
2022-02-25 14:20 ` Sudeep Holla
2022-02-23 12:55 ` [PATCH v6 2/3] dt-bindings: interrupt-controller: Add Qualcomm MPM support Shawn Guo
2022-02-23 12:55 ` [PATCH v6 3/3] irqchip: Add Qualcomm MPM controller driver Shawn Guo
2022-02-23 23:43 ` kernel test robot
2022-02-24 2:10 ` Shawn Guo
2022-02-25 8:54 ` Marc Zyngier [this message]
2022-05-04 14:08 ` [PATCH v6 0/3] Add Qualcomm MPM irqchip driver support Ulf Hansson
2022-05-04 19:21 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eff0caf8a8a10f0e8bf99bc9f949c5d@kernel.org \
--to=maz@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=quic_mkshah@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).