Re: [PATCH] ARM: dts: BCM53573: Fix address of Luxul XAP-1440's Ethernet PHY

["Rafał Miłecki" <zajec5@gmail.com>]

W dniu 6.10.2025 o 18:09, Andrew Lunn pisze:
> On Thu, Oct 02, 2025 at 09:48:52PM +0200, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Luxul XAP-1440 has BCM54210E PHY at address 25.
>>
>> Fixes: 44ad82078069 ("ARM: dts: BCM53573: Fix Ethernet info for Luxul devices")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>   arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
>> index ac44c745bdf8..a39a021a3910 100644
>> --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
>> +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
>> @@ -55,8 +55,8 @@ &gmac0 {
>>   	mdio {
>>   		/delete-node/ switch@1e;
>>   
>> -		bcm54210e: ethernet-phy@0 {
>> -			reg = <0>;
>> +		bcm54210e: ethernet-phy@25 {
>> +			reg = <25>;
> 
> Does this really not work, or is it relying on the PHY responding to 0
> as a broadcast address?

Invalid PHY address was breaking Linux's support for Ethernet device.

Before this change:
[    0.986560] bgmac_bcma bcma0:5: Found PHY addr: 25
[    0.991913] mdio_bus bcma_mdio-0-0: MDIO device at address 0 is missing.
[    1.024512] libphy: PHY bcma_mdio-0-0:19 not found
[    1.029358] bgmac_bcma bcma0:5: PHY connection failed
[    1.034514] bgmac_bcma bcma0:5: Cannot connect to phy