From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Richard Acayan <mailingradian@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-media@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v5 4/7] dt-bindings: media: camss: Add qcom,sdm670-camss
Date: Tue, 1 Oct 2024 12:03:32 +0200 [thread overview]
Message-ID: <8f11c99b-f3ca-4501-aec4-0795643fc3a9@kernel.org> (raw)
In-Reply-To: <652b3b74-65d0-479c-a863-7e8f32be7fc9@linaro.org>
On 01/10/2024 11:54, Bryan O'Donoghue wrote:
> On 01/10/2024 10:47, Krzysztof Kozlowski wrote:
>>> These are appearing in address order, which is preferred over reg-name
>>> ordering AFAIU.
>> First time I hear about such rule. Where is this ordering preference
>> documented? We always ask to keep the same order in each file.
>
> Eh evidently just my impression because we sort nodes by address.
>
> Yes, definitely agree both the regs and interrupts should be sorted the
> same way, its inconsistent to have one set sorted by address but the
> other sorted by name.
I don't imply sorting by name is any better. The only rule is that all
devices from same family type must have the same order. This is even
explicitly expressed for several devices by sharing binding or sharing
bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-01 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 2:35 [PATCH v5 0/7] Add SDM670 camera subsystem Richard Acayan
2024-10-01 2:35 ` [PATCH v5 1/7] dt-bindings: clock: qcom,sdm845-camcc: add sdm670 compatible Richard Acayan
2024-10-01 2:35 ` [PATCH v5 2/7] dt-bindings: i2c: qcom-cci: Document SDM670 compatible Richard Acayan
2024-10-01 6:49 ` Krzysztof Kozlowski
2024-10-01 2:35 ` [PATCH v5 3/7] i2c: qcom-cci: Stop complaining about DT set clock rate Richard Acayan
2024-10-01 2:35 ` [PATCH v5 4/7] dt-bindings: media: camss: Add qcom,sdm670-camss Richard Acayan
2024-10-01 6:53 ` Krzysztof Kozlowski
2024-10-01 9:09 ` Bryan O'Donoghue
2024-10-01 9:47 ` Krzysztof Kozlowski
2024-10-01 9:54 ` Bryan O'Donoghue
2024-10-01 10:03 ` Krzysztof Kozlowski [this message]
2024-10-01 2:35 ` [PATCH v5 5/7] media: qcom: camss: add support for SDM670 camss Richard Acayan
2024-10-01 2:35 ` [PATCH v5 6/7] arm64: dts: qcom: sdm670: add camcc Richard Acayan
2024-10-01 2:35 ` [PATCH v5 7/7] arm64: dts: qcom: sdm670: add camss and cci Richard Acayan
2024-10-02 8:53 ` [PATCH v5 0/7] Add SDM670 camera subsystem Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f11c99b-f3ca-4501-aec4-0795643fc3a9@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).