From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49F64303CB0 for ; Wed, 12 Nov 2025 10:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762944969; cv=none; b=TvGgZMuj8K7d9gFZxKaEm/LyT+c70zVZSasvs9kHrl6LmKEu9TMWKJ/NacCWjGGDYmrFy5QRuFYEZ0RvWWN8WGsE+R0mm8U6ddDU73JiWhBvKlECJ1htKbRV6H/qw6rR/fePYZ+4iFA1lGm/l07eBWqKOdnB9duG16HR1jflOcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762944969; c=relaxed/simple; bh=ZzpEI9WgfiZ5kliVes5Y9Jfc8V8uQhcrISym6yczJ2I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IvMO+b2bwmjaL8j7EPEfMFrZFglrpME8ou6gAuJx8t62Afq8snhaHFlseJuEs3fKfZCzhzUrkExJ6zo+8yg+EhbrCfThrXm4n/op6asHE5cPyULuEWWNBhuEMBSGvr6bqBpHQvaETqqmfccQnOT3kTjsUEa5d/D8B/4739zBm90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YlTfbT+T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jtISGwLA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YlTfbT+T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jtISGwLA" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AC9gjx71109210 for ; Wed, 12 Nov 2025 10:56:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q7J8baXgxyTkhN2ZdMYqtwC3Hhdgc0z63es0iUEKVbE=; b=YlTfbT+TpP6Q//J2 88dZBFYjCM7mJWQbvLvCgNBnt79B1djKmdfOGuzl/+iuS3qaHSbgt8nZm9geeWJM EwucGUm3IpaplnqdDfeWTdrpoCVvJeAa0SlphjJx/CipbmbNbfOWCvoG9sMatwTH tHQ/dxIhZuY1GhAaGECAtuO+JzvLQACttntfzqIZC7a19Cw7Bzvqfd0Re5N1viYa OGTENQuDwMfZhdelpH3rWa43UBIvTuMqKThNYEGIjsZjkllXWb++ZOtls0/VL7U2 NUr1jhbOIGY/esw833NUGvru2Hdy5K62Xkeftl/wTpZSV2SxrX/ssMhfqEsxgAec VRvoBA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4acqum076c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Nov 2025 10:56:06 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4edaa289e0dso2606241cf.3 for ; Wed, 12 Nov 2025 02:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762944965; x=1763549765; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q7J8baXgxyTkhN2ZdMYqtwC3Hhdgc0z63es0iUEKVbE=; b=jtISGwLAumaL3cq/Xvoi3TWYMeYMkMJQ+webV257MiqHE1m6pJwvvP7b2cz7ifbjGT pMWNRUXleQnDf7OMXfvAu+VT05Ki9ihhk4PRGCgfs1tCLv8MvbU8NO9RzvLu0OQOhO1W kSKHSjIcIyrWSMkB1N2PQm0/xx1s7CRY4E6U2fdCIYMG9pmX/zFpfxrPRKPoEYK8imaX /DYQhqzZHlp7RQAU1lmHwUW9yXyGBm3iVPWLgrheq870MwIUYKZ+PiQ2sIMt+TiX0PNa Ksnn3g/JIRCi2zVjTNx3ygED099EpRyY1JGkPVoef0U9Cp1SulV028ckMY5nTXZZiSm3 PVuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762944965; x=1763549765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q7J8baXgxyTkhN2ZdMYqtwC3Hhdgc0z63es0iUEKVbE=; b=VwXVWE8rW80q6quNyfRUnMZoRfuMMSL3cx4f2NpM9F3L3CtCLT8cLyNP1N/rRPoaU5 uu5ByjovXGG4RyTCO54M5vsyldanElBm2/aWUqSvUKbi+YFgbVshPKW4597D/urGEiO+ k1ird+/Re+XKcQJx6mdhSCEr1tfvWLjx9UAEky7q4D08furBu6kNSvMPQ1g7XdpAUblc OWA2Rr3eV5m/WN6torGiuiNUR2/L0oRnUbZuv+dKzusWMJkfqqaULlum6UFRAG9R1+Lr wgyQQxXg42Ysg0D3Ga4PLwM+bv1xCdgMH9J+b0Qju/fIkOjeqw1OTNneSsIXllrZVT0Y 4a+Q== X-Forwarded-Encrypted: i=1; AJvYcCUxArkFVhJa0/IHg6ze834w/KlVP6TGB/EHCqcdKXTpK0A/6yDegVrkxbR2JedpGeXXOBW9QxO6Xpkq@vger.kernel.org X-Gm-Message-State: AOJu0YwtxyEJW/DdxLYziLHvNGnCHUI0Xgfxwoz/kQGudjLaD2QQKrYa MWVV3/WoEUiwYFty/eu9WtFSAyNP6I7Aec9QEEC/FfsGpb7R+ZA1A/JRmQzX+2tKIFWg460a5G+ 5j6w48K4aotIKOgF+nKrh2k3u64BXx8x889Y49L3lpzRdYNnr+mA1iFnoJjumz26sf4rrIcud X-Gm-Gg: ASbGncsbAtaajdj80nxXR7bX2AE+VulNWoHT/elg9sdACVxwG9Iw0Zb06AxISX0eoS2 mfl32w+0teUAK2+p7z3Aah6vJwQoctci2dJCxlOOCh43wqlDZumMHRwzRkXHqqecMJK02KQ+zp4 mTyqzdwvwOzllMDOtyLIlv0tPK3E7cDAEDzBXZ7Uon0Yoz3x9y06AHARDHWsztVbQ49j3FzfReG jcgDuIVF6x2LoQas01JDI3aw8kOtQ6mIoc4rb35cikvGjwe/iaY98MInglz3Jr3orNmevIw92L9 j08uc+/MMmOZHO3sZfkdAH2ZnikoN+hYHlGQ0t22Rymtb1qRSkNhHVxj9+v5DYIT3uOpdEiZRL9 QCpofMjU/J6auqzuZk3TVry3MrQE6JHa2hi/qXfM8ux7G5OQgfnvZZPtf X-Received: by 2002:a05:622a:5d12:b0:4ed:de8b:4436 with SMTP id d75a77b69052e-4edde8b4640mr9664961cf.12.1762944965500; Wed, 12 Nov 2025 02:56:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHehnHC4uvc/Oy+HlpbxtFmbNd/Io3lA6JdYlICTyBqU+FS0kyknsLAZ4U0LhGMGqz+5Q6+5A== X-Received: by 2002:a05:622a:5d12:b0:4ed:de8b:4436 with SMTP id d75a77b69052e-4edde8b4640mr9664541cf.12.1762944965047; Wed, 12 Nov 2025 02:56:05 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b73381dd3besm103142666b.43.2025.11.12.02.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 02:56:04 -0800 (PST) Message-ID: <8f1caccc-8a49-4c26-aeb4-f46f81593a30@oss.qualcomm.com> Date: Wed, 12 Nov 2025 11:56:00 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/21] drm/msm/a6xx: Rebase GMU register offsets To: Akhil P Oommen , Rob Clark , Bjorn Andersson , Konrad Dybcio , Sean Paul , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Jonathan Marek , Jordan Crouse , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Connor Abbott Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org References: <20251110-kaana-gpu-support-v2-0-bef18acd5e94@oss.qualcomm.com> <20251110-kaana-gpu-support-v2-9-bef18acd5e94@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251110-kaana-gpu-support-v2-9-bef18acd5e94@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEyMDA4NyBTYWx0ZWRfX1Elor61eQriT t80WRnUVbI67raCMZfBmAX5sV9zmuwvKE7fG7eEW/TF/hFS4NmJQLaNtwvWRr3DzxoUE6PzJvX/ cSdvALyh7ZoHrYq9c47N9jCQU/h+pDl/RzxXvmImYDFRVgy3dTRTTwyivkQviyX2KJuJDqL2izV A2t5hQBpI5DMHIHkfcVGCUQHqmYkisthWP5UeTC0OXabPJ3K8VQyD/mjHAXLPu/jlYEweHg3Kq5 vSGHRK0k2SIfqkhVzVxWuM5lReQZhhFd3z/2hud0+um3HJxoolZ1xNw2sxbK8lT+wRrwk3tpgjX Res9mpZx9N1qRxCUvv0veXWpFjjHsga4Oq2laSs5Ga7vh23Z6jyTLTwrzDY2reUg2Uj2KgVCiYY /CcwuSaWh+FmmrXXXFe/CSkdUEAvBw== X-Proofpoint-GUID: cpZiI5ntw-YbIqBa8ZmoeByGNz--ASYj X-Proofpoint-ORIG-GUID: cpZiI5ntw-YbIqBa8ZmoeByGNz--ASYj X-Authority-Analysis: v=2.4 cv=KeTfcAYD c=1 sm=1 tr=0 ts=691467c6 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LTedVN9yYKzQwah-PCsA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-12_03,2025-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511120087 On 11/10/25 5:37 PM, Akhil P Oommen wrote: > GMU registers are always at a fixed offset from the GPU base address, > a consistency maintained at least within a given architecture generation. > In A8x family, the base address of the GMU has changed, but the offsets > of the gmu registers remain largely the same. To enable reuse of the gmu > code for A8x chipsets, update the gmu register offsets to be relative > to the GPU's base address instead of GMU's. > > Signed-off-by: Akhil P Oommen > --- The resulting diff is a little convoluted, but I think it generally does the right thing [...] > +static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, > + const char *name, resource_size_t *start) > +{ > + void __iomem *ret; > + struct resource *res = platform_get_resource_byname(pdev, > + IORESOURCE_MEM, name); > + > + if (!res) { > + DRM_DEV_ERROR(&pdev->dev, "Unable to find the %s registers\n", name); > + return ERR_PTR(-EINVAL); > + } > + > + ret = ioremap(res->start, resource_size(res)); > + if (!ret) { > + DRM_DEV_ERROR(&pdev->dev, "Unable to map the %s registers\n", name); > + return ERR_PTR(-EINVAL); > + } You can use devres here too, devm_platform_get_and_ioremap_resource() Konrad