From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7722F33086 for ; Wed, 8 Jan 2025 09:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329094; cv=none; b=AXoDgeuHh1DbiTCXntLAwAYj/Ac2h3smcsLgBv0wAOSQJj6qVw+0wENzJe60Gyj10SUhAHVem+r4mB4PcbyRqYCHwD89tjWPQvj3C52YhQg0MjWiE6vNyn5aTWPmWeCOa+DknUIID9G+m2Fltc9ld+DZ2Odyqj7XGc0M3/7Si9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736329094; c=relaxed/simple; bh=mxY3hHGAPD58iSFHT8K2AinLWZdc4QdiH7ZU1sxLT3M=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=gMEXkslBlQiwB1SlANNfwsuVUjNqXIbr/twG8Jc7sghqFjuI79aH7D35tq4nLf5Dn1N1eaPf657gajUPmUtPWnXgvOxZj2G21T/w+anGKVg7kXL1MeefxzH2rNBmlFwng6s0CoosLR9AkCwjgYrvN9AwFEuI3zRDkFnMmxXWI+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EHn8Wzvd; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EHn8Wzvd" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38a25d4b9d4so6278988f8f.0 for ; Wed, 08 Jan 2025 01:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736329091; x=1736933891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=SRu1D7dGFpm2VosF+UybZYQj2P1M1/nlzDOmVqBRd/k=; b=EHn8Wzvde6aXxRcflEoP7Uuo9Czxfn98+78YepMwjt65CmvNRqQlVfmnY27/PurK8r 01JU1r84PlU9vy88rTNsZ/beKQ0VhkTOZNrENARCnvubsITYROY92FinSGuIxs8EUpsb 5nBMJDu6fzzzB69bhoH6guHnkm3SvdphRh4rwjKhzyL3mnZ8CTjLi1x76xe6ItsQnWag KNUBaqFmF44BsMOuJtIITUVKqSWbIww6rtHyEbfb+0DOwaSzsiZm8pIjn2/opBkAoEYj zHpu48bldcq8bNy1g+IhupdBDGG2mMa8StlcYNS5RiCndlQIVLP26LrmVEtlX5NbH6to UKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736329091; x=1736933891; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SRu1D7dGFpm2VosF+UybZYQj2P1M1/nlzDOmVqBRd/k=; b=Zjo2ymTTzFVPyzRpvaj2uUmd5Mz5Qsl17z1412vyxzA7GfCXcLaGzIS9y/6DAc70wK bzMW9Pa+rZACWKjBIOp8RpMPn1wApvrsG3WrEy7Ge7KuCCbr0tz8iIFEmd8gnp5vIABD XRatw7s7BT1CoFC0Dkq1m/8MNRfJyi3MyvfJGMee2r5h/9iKn4Z36r7psS1+kyYfh26l Shlbmch+un85cZaZVPiZe/GhE9Rm2GhRlPQPCjTwqDmvfOSCzD4spyO47hjXHwvPyRqj sNtaQG3dlDwzRMVa34oYOz+wTJ0H+hPiMenj5p4jMiSrs/ONVxc5BIocwd7QdCZuci94 H5YA== X-Forwarded-Encrypted: i=1; AJvYcCX1GKUCFOUbtQe9Y5wA+NDAlTQbzsZPoS4nTbLRnmPcDg02nTVJQ3kMgVcR4vPbj6a/7bbVHLfMJVwr@vger.kernel.org X-Gm-Message-State: AOJu0YwbluvfJHTE8lGCa6SJhpc1vOVuj8ggEdO188ZCtm9E/PZ9c7S8 db3meBqwjv72aGhzQ73WYXK+J6kNQiCuzLXlkYgiOkBoXKikNBvFPyDl0UvDuQg= X-Gm-Gg: ASbGncvs5+RDcCmdi3o0ddx0nh/k/Rd+l1yRO7NsKCx0D27+Osyoz43Zwa3FulAK/rv fYOrQEhM1MkvVin8z+IkfzGlu2hfD4WmG3iN+Al8IKPD7Q/ZamavmJN4j1+V1ldN+zmfpLUabWN 1+lxSyhvsIvSy8DxX+kV11ZlVu5hnV0nTsowol7jlJeMDOLi9AeM64nURyUBMeF33dBzRYgTpSV UBkXJdZdz1oSBAxQs2nyVWEzgkJAumVWagunnZqiX4pT7FsJ4cdq297ckOjh2Yr X-Google-Smtp-Source: AGHT+IEgum97jZJPYPy0T8bJnOriFmAqzwKIgHxRt19SfRXXojRd9i53LcCXOyDAxP3gnyZZAo45SQ== X-Received: by 2002:adf:b1dc:0:b0:38a:88bc:ace1 with SMTP id ffacd0b85a97d-38a88bcadc9mr703276f8f.34.1736329090756; Wed, 08 Jan 2025 01:38:10 -0800 (PST) Received: from [192.168.0.14] ([188.26.61.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd1682e4sm23612385e9.1.2025.01.08.01.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 01:38:10 -0800 (PST) Message-ID: <8f21d5f2-5327-488c-878c-a62d85857240@linaro.org> Date: Wed, 8 Jan 2025 09:38:08 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] dt-bindings: mailbox: add google,gs101-mbox From: Tudor Ambarus To: Jassi Brar Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski , Alim Akhtar , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, daniel.lezcano@linaro.org, vincent.guittot@linaro.org, ulf.hansson@linaro.org, arnd@arndb.de References: <20241217-acpm-v4-upstream-mbox-v5-0-cd1d3951fe84@linaro.org> <20241217-acpm-v4-upstream-mbox-v5-1-cd1d3951fe84@linaro.org> <4e97b33f-b4a5-4875-a65d-9e25bcc5a46c@linaro.org> Content-Language: en-US In-Reply-To: <4e97b33f-b4a5-4875-a65d-9e25bcc5a46c@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Jassi, On 1/3/25 9:57 AM, Tudor Ambarus wrote: >>> Then I updated the mailbox core to allow clients to request channels by >>> passing some args containing channel identifiers to the controllers, >>> that the controllers xlate() using their own method. >>> >> This is unnecessary. >> If you don't pass the doorbell number from DT, each channel populated >> by the driver is just a s/w construct or a 'virtual' channel. Make use >> of 'void *data' in send_data() to specify the doorbell. >> > I think this introduces concurrency problems if the channel identifiers > passed by 'void *data' don't match the virtual channel used for sending > the messages. Do we want to allow this? > > Also, if we use 'void *data' to pass channel identifiers, the channel > checks will have to be made at send_data() time. Thus if passing wrong > channel type for example, the mailbox client will eventually get a > -ENOBUFS and a "Try increasing MBOX_TX_QUEUE_LEN" message, which I find > misleading. Shall I still use 'void *data' to pass channel identifiers through send_data()? I'd like to respin everything. Thanks! ta