* [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
@ 2025-11-13 13:09 Wei Deng
2025-11-13 13:37 ` Krzysztof Kozlowski
2025-11-13 20:14 ` Dmitry Baryshkov
0 siblings, 2 replies; 6+ messages in thread
From: Wei Deng @ 2025-11-13 13:09 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
cheng.jiang, quic_jiaymao, quic_chezhou, quic_shuaz
Enable BT on qcs8300-ride by adding a device tree node for BT.
Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
---
This patch depends on:
- WLAN
https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
---
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index cd8800a59700..08b705fe4eea 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -18,6 +18,7 @@ / {
aliases {
serial0 = &uart7;
mmc0 = &sdhc_1;
+ serial1 = &uart2;
};
chosen {
@@ -71,6 +72,7 @@ wcn6855-pmu {
vddpcie1p3-supply = <&vreg_conn_pa>;
vddpcie1p9-supply = <&vreg_conn_1p8>;
+ bt-enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
regulators {
@@ -501,6 +503,13 @@ &sdhc_1 {
};
&tlmm {
+ bt_en_state: bt-en-state {
+ pins = "gpio55";
+ function = "gpio";
+ bias-pull-down;
+ output-low;
+ };
+
ethernet0_default: ethernet0-default-state {
ethernet0_mdc: ethernet0-mdc-pins {
pins = "gpio5";
@@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
};
};
+&uart2 {
+ status = "okay";
+
+ bluetooth: bluetooth {
+ compatible = "qcom,wcn6855-bt";
+ firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
+ max-speed = <3200000>;
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+ };
+};
+
&uart7 {
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
2025-11-13 13:09 [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support Wei Deng
@ 2025-11-13 13:37 ` Krzysztof Kozlowski
2025-11-13 13:38 ` Krzysztof Kozlowski
2025-11-13 20:14 ` Dmitry Baryshkov
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-13 13:37 UTC (permalink / raw)
To: Wei Deng, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
cheng.jiang, quic_jiaymao, quic_chezhou, quic_shuaz
On 13/11/2025 14:09, Wei Deng wrote:
> Enable BT on qcs8300-ride by adding a device tree node for BT.
>
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
> This patch depends on:
> - WLAN
> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
And that patch depends on something else.
You make it very difficult to review and even more difficult to merge.
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index cd8800a59700..08b705fe4eea 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -18,6 +18,7 @@ / {
> aliases {
> serial0 = &uart7;
> mmc0 = &sdhc_1;
There is no such alias?
> + serial1 = &uart2;
So every contributor here will add some random order...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
2025-11-13 13:37 ` Krzysztof Kozlowski
@ 2025-11-13 13:38 ` Krzysztof Kozlowski
2025-11-18 13:18 ` Wei Deng
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-13 13:38 UTC (permalink / raw)
To: Wei Deng, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
cheng.jiang, quic_jiaymao, quic_chezhou, quic_shuaz
On 13/11/2025 14:37, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:09, Wei Deng wrote:
>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>
>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - WLAN
>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>
> And that patch depends on something else.
>
> You make it very difficult to review and even more difficult to merge.
>
>> ---
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index cd8800a59700..08b705fe4eea 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -18,6 +18,7 @@ / {
>> aliases {
>> serial0 = &uart7;
>> mmc0 = &sdhc_1;
>
> There is no such alias?
Ah there is, found now added by Sayali Lokhande <quic_sayalil@quicinc.com>.
Anyway, organize your work in reasonable patchsets not 3 or more
one-patchers spread all over the mailing list.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
2025-11-13 13:38 ` Krzysztof Kozlowski
@ 2025-11-18 13:18 ` Wei Deng
0 siblings, 0 replies; 6+ messages in thread
From: Wei Deng @ 2025-11-18 13:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
cheng.jiang, quic_jiaymao, quic_chezhou, quic_shuaz
Hi Krzysztof,
Thanks for your comments.
On 11/13/2025 9:38 PM, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:37, Krzysztof Kozlowski wrote:
>> On 13/11/2025 14:09, Wei Deng wrote:
>>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>>
>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>> ---
>>> This patch depends on:
>>> - WLAN
>>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>>
>> And that patch depends on something else.
>>
>> You make it very difficult to review and even more difficult to merge.
>>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>>> 1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index cd8800a59700..08b705fe4eea 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -18,6 +18,7 @@ / {
>>> aliases {
>>> serial0 = &uart7;
>>> mmc0 = &sdhc_1;
>>
>> There is no such alias?
>
> Ah there is, found now added by Sayali Lokhande <quic_sayalil@quicinc.com>.
>
> Anyway, organize your work in reasonable patchsets not 3 or more
> one-patchers spread all over the mailing list.
>
OK, will re-organize my work in reasonable patchsets. Will send new patch.
> Best regards,
> Krzysztof
--
Best Regards,
Wei Deng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
2025-11-13 13:09 [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support Wei Deng
2025-11-13 13:37 ` Krzysztof Kozlowski
@ 2025-11-13 20:14 ` Dmitry Baryshkov
2025-11-14 9:40 ` Wei Deng
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-11-13 20:14 UTC (permalink / raw)
To: Wei Deng
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
linux-bluetooth, cheng.jiang, quic_jiaymao, quic_chezhou,
quic_shuaz
On Thu, Nov 13, 2025 at 06:39:42PM +0530, Wei Deng wrote:
> Enable BT on qcs8300-ride by adding a device tree node for BT.
>
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
> This patch depends on:
> - WLAN
> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> @@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
> };
> };
>
> +&uart2 {
> + status = "okay";
> +
> + bluetooth: bluetooth {
> + compatible = "qcom,wcn6855-bt";
> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
The reason for these firmware-names should be added to the commit
message.
> + max-speed = <3200000>;
> +
> + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> + vddaon-supply = <&vreg_pmu_aon_0p59>;
> + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> + vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
> + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> + vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
> + };
> +};
> +
> &uart7 {
> status = "okay";
> };
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
2025-11-13 20:14 ` Dmitry Baryshkov
@ 2025-11-14 9:40 ` Wei Deng
0 siblings, 0 replies; 6+ messages in thread
From: Wei Deng @ 2025-11-14 9:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
linux-bluetooth, cheng.jiang, quic_jiaymao, quic_chezhou,
quic_shuaz
Hi Dmitry,
Thanks for your comments.
On 11/14/2025 4:14 AM, Dmitry Baryshkov wrote:
> On Thu, Nov 13, 2025 at 06:39:42PM +0530, Wei Deng wrote:
>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>
>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - WLAN
>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>> ---
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> @@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
>> };
>> };
>>
>> +&uart2 {
>> + status = "okay";
>> +
>> + bluetooth: bluetooth {
>> + compatible = "qcom,wcn6855-bt";
>> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>
> The reason for these firmware-names should be added to the commit
> message.
>
Since the platform uses the QCA6698 Bluetooth chip. While the QCA6698
shares the same IP core as the WCN6855, it has different RF components
and RAM sizes, requiring new firmware files. Use the firmware-name property
to specify the NVM and rampatch firmware to load.
Will add this to commit message.
>> + max-speed = <3200000>;
>> +
>> + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
>> + vddaon-supply = <&vreg_pmu_aon_0p59>;
>> + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
>> + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
>> + vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
>> + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
>> + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
>> + vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
>> + };
>> +};
>> +
>> &uart7 {
>> status = "okay";
>> };
>> --
>> 2.25.1
>>
>
--
Best Regards,
Wei Deng
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-11-18 13:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 13:09 [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support Wei Deng
2025-11-13 13:37 ` Krzysztof Kozlowski
2025-11-13 13:38 ` Krzysztof Kozlowski
2025-11-18 13:18 ` Wei Deng
2025-11-13 20:14 ` Dmitry Baryshkov
2025-11-14 9:40 ` Wei Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).