From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index
Date: Wed, 6 Sep 2023 14:07:22 +0300 [thread overview]
Message-ID: <8f306f3b-ab43-411c-9cd3-9e03b93602ee@linaro.org> (raw)
In-Reply-To: <7bca9767-1112-4817-aac1-e6d720e92817@linaro.org>
On 06/09/2023 14:05, Dmitry Baryshkov wrote:
> On 06/09/2023 12:24, Konrad Dybcio wrote:
>> Newer RB1 board revisions have a debug UART on QUP0. Sadly, it looks
>
> Nit: I think this is '.. revisions should have...'. Because I was told
> that the board I got is the final design / production.
>
>> like even when ordering one in retail, customers receive prototype
>> boards with "Enginering Sample" written on them.
>>
>> Use QUP4 for UART to make all known RB1 boards boot.
>>
>> Fixes: e18771961336 ("arm64: dts: qcom: Add initial QTI RB1 device tree")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Ugh. This should have been:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
>> ---
>> arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
>> b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
>> index eadba066972e..5cda5b761455 100644
>> --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
>> +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
>> @@ -13,7 +13,7 @@ / {
>> compatible = "qcom,qrb2210-rb1", "qcom,qrb2210", "qcom,qcm2290";
>> aliases {
>> - serial0 = &uart0;
>> + serial0 = &uart4;
>> sdhc1 = &sdhc_1;
>> sdhc2 = &sdhc_2;
>> };
>> @@ -357,7 +357,7 @@ key_volp_n: key-volp-n-state {
>> };
>> /* UART connected to the Micro-USB port via a FTDI chip */
>> -&uart0 {
>> +&uart4 {
>> compatible = "qcom,geni-debug-uart";
>> status = "okay";
>> };
>>
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-09-06 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:24 [PATCH 0/5] RB1 features Konrad Dybcio
2023-09-06 9:24 ` [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index Konrad Dybcio
2023-09-06 11:05 ` Dmitry Baryshkov
2023-09-06 11:07 ` Dmitry Baryshkov [this message]
2023-09-06 9:24 ` [PATCH 2/5] arm64: dts: qcom: qrb2210-rb1: Fix regulators Konrad Dybcio
2023-09-06 9:38 ` Krzysztof Kozlowski
2023-09-06 11:05 ` Dmitry Baryshkov
2023-09-06 9:24 ` [PATCH 3/5] arm64: dts: qcom: qrb2210-rb1: Enable remote processors Konrad Dybcio
2023-09-06 11:07 ` Dmitry Baryshkov
2023-09-06 9:24 ` [PATCH 4/5] arm64: dts: qcom: qrb2210-rb1: Add GPIO LEDs Konrad Dybcio
2023-09-06 9:24 ` [PATCH 5/5] arm64: dts: qcom: qrb2210-rb1: Hook up USB3 Konrad Dybcio
2023-09-06 11:07 ` Dmitry Baryshkov
2023-09-20 2:14 ` [PATCH 0/5] RB1 features Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f306f3b-ab43-411c-9cd3-9e03b93602ee@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).