From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3187410953 for ; Wed, 8 Nov 2023 10:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oWFkTutF" Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99725170F for ; Wed, 8 Nov 2023 02:06:19 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77a453eb01cso436283985a.0 for ; Wed, 08 Nov 2023 02:06:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699437979; x=1700042779; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rr7gS752VmDAnEEC2uCNu6BHcbWN9XZEmhatGiJJf1A=; b=oWFkTutFxvQq6N86TQjSF5P/JEESnp0OXvRK+kS4lbEIQcoNBum9JQT1+l2DHKmYc7 iUlY8QqpuWk1bst4hsNbgFo0fNVfuzdDW56NZXL64Fr1nm5lKANcKOtQe58/RH6sILIn x5d3rQExSc3wvwzteygysIb3M8sD6IYUAQmSMCZIWPWUrsWq4Tol/vws/KkumnGhphOw dsaEI9GUW5kpykmWu/F69yrVUlVcb1r+nfxni1T1VS251ioWmZa5k+PfAfaxPjx1Nfia rvC0JjQnyEmo9WPfCz/vuRF92bbKABSc+8B2SmoJz2jpkBVa0VeSSa+8zo2x28ONVJKm YYlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699437979; x=1700042779; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rr7gS752VmDAnEEC2uCNu6BHcbWN9XZEmhatGiJJf1A=; b=GbE9OqmutFqn1Y6NPkz3SYPykVb3W/JAMhM5uYXf9bloMjuR/OK/DI5nZ04AsS+ErU 1o2dkJW1QhZ8llYbC2nR410nVSmCISaQgcaBW6GWK5Y+cKZqgxSMPY5DLP71ZboiVnMx +tSqwpW9YAMAlTm2Q3DAp8GABcNmNbjUwa7aYwX4sovtAd7r3THM9hUbX69jTWaUrpgm u6MUkcj4T7jP2ctsvVznMQxegzmgiS+faW4XtCtrSGJ8QkdzN1VM6TIxWHlRQZnPnBS9 HNNk2fTaXyzyqu1bBFRdheGDJ74YtmTr5xZ6IFk9vYP+LN62555ofcYOKMbFTrMEuit9 biuA== X-Gm-Message-State: AOJu0YwNfr8voX/38k+nITD7PF66yJ2me8nzqS4+KkrboRdoEERwgvv3 NCzeLWfjgOta4uomUp55polY3g== X-Google-Smtp-Source: AGHT+IGx7lgqtx9S/oyIp/5xMeMdu5UbG0dUZcFvMTcnc6s3J0nohJbZResltcIJRIscBeM3h7M0qQ== X-Received: by 2002:a05:620a:4055:b0:77b:9a8c:b0b5 with SMTP id i21-20020a05620a405500b0077b9a8cb0b5mr1278087qko.57.1699437978763; Wed, 08 Nov 2023 02:06:18 -0800 (PST) Received: from [172.30.205.23] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id w2-20020a05620a0e8200b007789a3499casm858664qkm.115.2023.11.08.02.06.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 02:06:18 -0800 (PST) Message-ID: <8f7db00f-aae0-43d9-bd6a-47374a91d546@linaro.org> Date: Wed, 8 Nov 2023 11:06:12 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: qcom: Add LPG LED device description Content-Language: en-US To: Dmitry Baryshkov , quic_huliu@quicinc.com Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_fenglinw@quicinc.com, quic_uchheda@quicinc.com, kamalw@qti.qualcomm.com References: <20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/8/23 07:59, Dmitry Baryshkov wrote: > On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay > wrote: >> >> From: Hui Liu >> >> Add LPG LED device description. > > No. You are not adding "LPG LED device description". You are adding > definition for three LEDs. > >> >> Signed-off-by: Hui Liu >> --- Aside from Dmitry's valid comments, the subject is wrong. ARM points to arch/arm/ (arm32) and you're missing the name of the file that you're modifying. Check the git log for that file to get a grasp of it. Konrad