* [PATCH] ARM: dts: qcom: Add LPG LED device description
@ 2023-11-08 6:05 Hui Liu via B4 Relay
2023-11-08 6:59 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Hui Liu via B4 Relay @ 2023-11-08 6:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_fenglinw,
quic_uchheda, kamalw, Hui Liu
From: Hui Liu <quic_huliu@quicinc.com>
Add LPG LED device description.
Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
---
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index f28e71487d5c..11b9f384d99c 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -4,6 +4,7 @@
*/
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/spmi/spmi.h>
&spmi_bus {
@@ -34,6 +35,27 @@ pm8350c_pwm: pwm {
compatible = "qcom,pm8350c-pwm";
#pwm-cells = <2>;
status = "disabled";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ label = "red";
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ label = "green";
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ label = "blue";
+ };
};
};
};
---
base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
change-id: 20231108-qcom_leds-c3b0b7029008
Best regards,
--
Hui Liu <quic_huliu@quicinc.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom: Add LPG LED device description
2023-11-08 6:05 [PATCH] ARM: dts: qcom: Add LPG LED device description Hui Liu via B4 Relay
@ 2023-11-08 6:59 ` Dmitry Baryshkov
2023-11-08 10:06 ` Konrad Dybcio
2023-11-10 1:55 ` hui liu
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-11-08 6:59 UTC (permalink / raw)
To: quic_huliu
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, quic_fenglinw, quic_uchheda, kamalw
On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
<devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>
> From: Hui Liu <quic_huliu@quicinc.com>
>
> Add LPG LED device description.
No. You are not adding "LPG LED device description". You are adding
definition for three LEDs.
>
> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> index f28e71487d5c..11b9f384d99c 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> @@ -4,6 +4,7 @@
> */
>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/spmi/spmi.h>
>
> &spmi_bus {
> @@ -34,6 +35,27 @@ pm8350c_pwm: pwm {
> compatible = "qcom,pm8350c-pwm";
> #pwm-cells = <2>;
> status = "disabled";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_RED>;
> + label = "red";
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_GREEN>;
> + label = "green";
> + };
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + label = "blue";
... and these particular LEDs are board-specific. Please fill them in
the board file instead.
> + };
> };
> };
> };
>
> ---
> base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
> change-id: 20231108-qcom_leds-c3b0b7029008
>
> Best regards,
> --
> Hui Liu <quic_huliu@quicinc.com>
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom: Add LPG LED device description
2023-11-08 6:59 ` Dmitry Baryshkov
@ 2023-11-08 10:06 ` Konrad Dybcio
2023-11-10 1:55 ` hui liu
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-11-08 10:06 UTC (permalink / raw)
To: Dmitry Baryshkov, quic_huliu
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
quic_fenglinw, quic_uchheda, kamalw
On 11/8/23 07:59, Dmitry Baryshkov wrote:
> On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
> <devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>>
>> From: Hui Liu <quic_huliu@quicinc.com>
>>
>> Add LPG LED device description.
>
> No. You are not adding "LPG LED device description". You are adding
> definition for three LEDs.
>
>>
>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
>> ---
Aside from Dmitry's valid comments, the subject is wrong.
ARM points to arch/arm/ (arm32) and you're missing the name of
the file that you're modifying. Check the git log for that file
to get a grasp of it.
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: Add LPG LED device description
2023-11-08 6:59 ` Dmitry Baryshkov
2023-11-08 10:06 ` Konrad Dybcio
@ 2023-11-10 1:55 ` hui liu
1 sibling, 0 replies; 4+ messages in thread
From: hui liu @ 2023-11-10 1:55 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, quic_fenglinw, quic_uchheda, kamalw
On 11/8/2023 2:59 PM, Dmitry Baryshkov wrote:
> On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
> <devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>>
>> From: Hui Liu <quic_huliu@quicinc.com>
>>
>> Add LPG LED device description.
>
> No. You are not adding "LPG LED device description". You are adding
> definition for three LEDs.
OK, I will update the commit in next patch.
>
>>
>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> index f28e71487d5c..11b9f384d99c 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> @@ -4,6 +4,7 @@
>> */
>>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/spmi/spmi.h>
>>
>> &spmi_bus {
>> @@ -34,6 +35,27 @@ pm8350c_pwm: pwm {
>> compatible = "qcom,pm8350c-pwm";
>> #pwm-cells = <2>;
>> status = "disabled";
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_RED>;
>> + label = "red";
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + label = "green";
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + label = "blue";
>
> ... and these particular LEDs are board-specific. Please fill them in
> the board file instead.
Sure, I will add these node in board file.
>
>> + };
>> };
>> };
>> };
>>
>> ---
>> base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
>> change-id: 20231108-qcom_leds-c3b0b7029008
>>
>> Best regards,
>> --
>> Hui Liu <quic_huliu@quicinc.com>
>>
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-10 1:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-08 6:05 [PATCH] ARM: dts: qcom: Add LPG LED device description Hui Liu via B4 Relay
2023-11-08 6:59 ` Dmitry Baryshkov
2023-11-08 10:06 ` Konrad Dybcio
2023-11-10 1:55 ` hui liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).