public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>,
	bryan.odonoghue@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
	loic.poulain@oss.qualcomm.com, rfoss@kernel.org,
	andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
	cros-qcom-dts-watchers@chromium.org
Cc: quic_svankada@quicinc.com, linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Ravi Shankar <quic_rshankar@quicinc.com>,
	Vishal Verma <quic_vishverm@quicinc.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
Date: Tue, 10 Feb 2026 13:51:02 +0100	[thread overview]
Message-ID: <8f8d7469-5edb-4718-997e-9cd01f7a9689@kernel.org> (raw)
In-Reply-To: <d63a0663-626e-416c-a5b4-e7d91f158b44@quicinc.com>

On 10/02/2026 13:42, Nihal Kumar Gupta wrote:
> 
> 
> On 09-02-2026 22:08, Krzysztof Kozlowski wrote:
>>> Krzysztof, Thanks for your review.
>>> All patches posted here were build‑tested and verified by the author.
>> Then please explain reported by Rob build-process warnings.
> 
> The dt-binding for qcom,qcs8300-cci specifies two clocks:
> clock-names = "ahb", "cci";
> 
> On Monaco, the CCI node currently defines:
> clock-names = "cpas_ahb", "cci";
> 
> The dt-binding warns because it expects the clock-names to be "ahb" and
> "cci", while the Monaco DTS uses "cpas_ahb" instead of "ahb". The
> hardware works correctly, but the name doesn't match the binding.
> Renaming "cpas_ahb" to "ahb" aligns the DTS with the binding and clears
> the warning. Please advise if you prefer a different approach.

I said this was not build-time tested. I gave a proof of that.

You said it was build tested but you confirm it has build error.

Listen, when tools report you errors and maintainers say your code does
not pass basic tests, don't insist that this was basic tested.

It was not and discussing this just wastes our time. I am not going to
spend more time on this discussion, wasted already too much.

Best regards,
Krzysztof

  reply	other threads:[~2026-02-10 12:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Nihal Kumar Gupta
2026-02-04 15:58   ` Andi Shyti
2026-02-06 16:34     ` Krzysztof Kozlowski
2026-02-06 16:34   ` Krzysztof Kozlowski
2026-01-21 18:31 ` [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions Nihal Kumar Gupta
2026-02-06 16:37   ` Krzysztof Kozlowski
2026-02-09 16:14     ` Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 3/5] arm64: dts: qcom: monaco: Add camera MCLK pinctrl Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators Nihal Kumar Gupta
2026-02-06 16:15   ` Vladimir Zapolskiy
2026-01-21 18:31 ` [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Nihal Kumar Gupta
2026-02-06 16:39   ` Krzysztof Kozlowski
2026-02-09 16:36     ` Nihal Kumar Gupta
2026-02-09 16:38       ` Krzysztof Kozlowski
2026-02-10 12:42         ` Nihal Kumar Gupta
2026-02-10 12:51           ` Krzysztof Kozlowski [this message]
2026-02-11 13:39             ` Nihal Kumar Gupta
2026-01-22  3:10 ` [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f8d7469-5edb-4718-997e-9cd01f7a9689@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=quic_nihalkum@quicinc.com \
    --cc=quic_rshankar@quicinc.com \
    --cc=quic_svankada@quicinc.com \
    --cc=quic_vishverm@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox