Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor

[Stefan Wahren <wahrenst@gmx.net>]

Hi,

Am 03.09.26 um 20:42 schrieb Peter Robinson:
> Hi Andrea,
>
>>> The thermal sensors on the bcm2712 (rpi5) are the same
>>> infrastructure as on the bcm2711 (rpi4) so add those
>>> details so we can get thermal monitoring on the device
>>> as it can get quite hot.
>>>
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>>> Cc: Florian Fainelli <florian.fainelli@broadcom.com>
>>> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com
>>> ---
>>>   arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 32 +++++++++++++++++++++++
>>>   1 file changed, 32 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> index ae1fc9d728c00..c73ed9e066662 100644
>>> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> @@ -508,6 +508,18 @@ hdmi1: hdmi@7c706400 {
>>>                        ddc = <&ddc1>;
>>>                        status = "disabled";
>>>                };
>>> +
>>> +             avs_monitor: avs-monitor@7d542000 {
>>> +                     compatible = "brcm,bcm2711-avs-monitor",
>>> +                                             "syscon", "simple-mfd";
>>> +                     reg = <0x7d542000 0xf00>;
>>> +                     status = "okay";
>>> +
>>> +                     thermal: thermal {
>>> +                             compatible = "brcm,bcm2711-thermal";
>>> +                             #thermal-sensor-cells = <0>;
>>> +                     };
>>> +             };
>>>        };
>>>
>>>        axi: axi {
>>> @@ -724,4 +736,24 @@ hvs: hvs@107c580000 {
>>>                interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof";
>>>                status = "disabled";
>>>        };
>>> +
>>> +     thermal-zones {
>>> +             cpu_thermal: cpu-thermal {
>>> +                     polling-delay-passive = <1000>;
>>> +                     polling-delay = <1000>;
>>> +                     coefficients = <(-550) 450000>;
>>> +                     thermal-sensors = <&thermal>;
>>> +
>>> +                     thermal_trips: trips {
>>> +                             cpu_crit: cpu-crit {
>>> +                                     temperature     = <110000>;
>>> +                                     hysteresis      = <0>;
>>> +                                     type            = "critical";
>>> +                             };
>>> +                     };
>>> +
>>> +                     cooling_maps: cooling-maps {
>>> +                     };
>>> +             };
>>> +     };
>>>   };
>>> --
>>> 2.55.0
>>>
>> Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
> It should apply cleanly against Florian's next branch here:
> https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next
this branch based on 7.2-rc1, not sure this is intended.