public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Judith Mendez <jm@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Moteen Shah <m-shah@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH v2 1/5] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default
Date: Sat, 19 Apr 2025 20:30:39 +0530	[thread overview]
Message-ID: <8f9aad2c-8e51-409e-be90-21230a53a4cf@ti.com> (raw)
In-Reply-To: <20250417233040.3658761-2-jm@ti.com>


On 4/18/2025 5:00 AM, Judith Mendez wrote:
> Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
> for eMMC. This change is necessary since DM is not implementing the
> correct procedure to switch PLL clock source for eMMC and we have a
> non-glich-free mux. To remove any potential issues, lets switch back to
> the defaults.

IMO, we need to fix DM  if not then documentation [0] .

Then only this patch is ok because as per document [0]

removed clock by this patch is valid parent for eMMC.

[0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j722s/clocks.html

Thanks

Udit

>
> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
> Fixes: d3ae4e8d8b6a ("arm64: dts: ti: k3-am62a-main: Add sdhci0 instance")
> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi               | 2 --
>   arch/arm64/boot/dts/ti/k3-am62a-main.dtsi              | 2 --
>   arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
>   3 files changed, 6 deletions(-)
>
> [..]

  reply	other threads:[~2025-04-19 15:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 23:30 [PATCH v2 0/5] Misc MMC updates Judith Mendez
2025-04-17 23:30 ` [PATCH v2 1/5] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default Judith Mendez
2025-04-19 15:00   ` Kumar, Udit [this message]
2025-04-21 14:36     ` Judith Mendez
2025-04-22  4:08       ` Kumar, Udit
2025-04-22 12:37       ` Nishanth Menon
2025-04-22 14:08         ` Kumar, Udit
2025-04-22 17:17           ` Judith Mendez
2025-04-22 17:21             ` Kumar, Udit
2025-04-25 22:01         ` Judith Mendez
2025-04-17 23:30 ` [PATCH v2 2/5] arm64: dts: ti: k3-am6*: Add boot phase flag to support MMC boot Judith Mendez
2025-04-22  5:45   ` Moteen Shah
2025-04-17 23:30 ` [PATCH v2 3/5] arm64: dts: ti: k3-am65-main: Add missing taps to sdhci0 Judith Mendez
2025-04-22  5:00   ` Moteen Shah
2025-04-17 23:30 ` [PATCH v2 4/5] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC Judith Mendez
2025-04-19 14:47   ` Kumar, Udit
2025-04-17 23:30 ` [PATCH v2 5/5] arm64: dts: ti: k3-am6*: Remove disable-wp " Judith Mendez
2025-04-22  6:08   ` Moteen Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f9aad2c-8e51-409e-be90-21230a53a4cf@ti.com \
    --to=u-kumar1@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jm@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox