From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>, linux-kernel@vger.kernel.org
Cc: Conor Dooley <conor.dooley@microchip.com>,
Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, imx@lists.linux.dev,
loongarch@lists.linux.dev
Subject: Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1
Date: Wed, 17 Jul 2024 11:39:08 +0200 [thread overview]
Message-ID: <8f9c3428-c5fa-462b-af9b-0224976a1165@kernel.org> (raw)
In-Reply-To: <20240717-parrot-malt-83cc04bf6b36@spud>
On 17/07/2024 11:37, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The Rohm dh2228fv (really the bh2228fv, the compatible in the kernel has
> a typo) does not support frequencies above 10 MHz, nor per the
> datasheet appear to use either CPOL or CPHA. I suspect that this
> devicetree is abusing the compatible in order to bind the spidev driver
> in Linux. Pretending to have devices on a board for this purpose is not
> acceptable, so remove it.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> I could not find any documentation for this board online, and it does
> not blatantly say that the device is a "spidev" like other [ab]users, so
> it is possible there's actually a DAC here - but I doubt it is a
> bh2228fv given the other incompatibilities.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-17 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 9:37 [PATCH v1 0/4] Removal of non-existent DAC nodes Conor Dooley
2024-07-17 9:37 ` [PATCH v1 1/4] arm64: dts: imx8: remove non-existent DACs Conor Dooley
2024-07-17 9:38 ` Krzysztof Kozlowski
2024-08-12 9:43 ` Shawn Guo
2024-07-17 9:37 ` [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1 Conor Dooley
2024-07-17 9:39 ` Krzysztof Kozlowski [this message]
2024-07-17 10:18 ` Heiko Stübner
[not found] ` <CAP9ODKrpKDY91AFDYj7s++kU+=CSLw=F9mXyLZ621Mqq-8S6bw@mail.gmail.com>
2024-07-17 15:34 ` Fabio Estevam
2024-07-17 16:39 ` Conor Dooley
2024-07-17 16:46 ` Fabio Estevam
2024-07-18 4:20 ` Dragan Simic
2024-07-18 4:46 ` Dragan Simic
2024-07-17 9:37 ` [PATCH v1 3/4] loongarch: dts: remove non-existent DAC from 2k1000-ref Conor Dooley
2024-07-17 9:39 ` Krzysztof Kozlowski
2024-07-17 9:37 ` [PATCH v1 4/4] ARM: dts: socfpga: remove non-existent DAC from CycloneV devkit Conor Dooley
2024-07-17 9:39 ` Krzysztof Kozlowski
2024-12-29 10:09 ` (subset) " Krzysztof Kozlowski
2025-02-12 20:49 ` (subset) [PATCH v1 0/4] Removal of non-existent DAC nodes Krzysztof Kozlowski
2025-02-13 20:05 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f9c3428-c5fa-462b-af9b-0224976a1165@kernel.org \
--to=krzk@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).