From: Krzysztof Kozlowski <krzk@kernel.org>
To: wens@csie.org, Chris Morgan <macroalpha82@gmail.com>
Cc: linux-sunxi@lists.linux.dev, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
p.zabel@pengutronix.de, sboyd@kernel.org,
mturquette@baylibre.com, samuel@sholland.org,
jernej.skrabec@gmail.com, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3] clk: sunxi-ng: h616: Add clock/reset for GPADC
Date: Tue, 28 May 2024 18:07:22 +0200 [thread overview]
Message-ID: <8f9d62c1-12f5-4d52-a511-602281857dbe@kernel.org> (raw)
In-Reply-To: <CAGb2v67rqiCA=fwk9USr4-xh3uRGxQ-p_f+--Ui5vVBnb10QQA@mail.gmail.com>
On 28/05/2024 18:02, Chen-Yu Tsai wrote:
> On Thu, Apr 18, 2024 at 1:04 AM Chris Morgan <macroalpha82@gmail.com> wrote:
>>
>> From: Chris Morgan <macromorgan@hotmail.com>
>>
>> Add the GPADC required clock and reset which is used for the onboard
>> GPADC.
>>
>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>> ---
>> drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 5 +++++
>> drivers/clk/sunxi-ng/ccu-sun50i-h616.h | 2 +-
>
>
>> include/dt-bindings/clock/sun50i-h616-ccu.h | 1 +
>> include/dt-bindings/reset/sun50i-h616-ccu.h | 1 +
>
> These need an Ack from the DT binding maintainers. And it's better to
> split these into a separate patch.
I am surprised that they were combined... So usual comment: Please split
the bindings, because we do not want bindings to be in the same commit
as driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-28 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:04 [PATCH 0/3] Add GPADC for Allwinner H616 Chris Morgan
2024-04-17 17:04 ` [PATCH 1/3] clk: sunxi-ng: h616: Add clock/reset for GPADC Chris Morgan
2024-04-17 20:26 ` Jernej Škrabec
2024-04-17 22:55 ` Andre Przywara
2024-05-28 16:02 ` Chen-Yu Tsai
2024-05-28 16:07 ` Krzysztof Kozlowski [this message]
2024-04-17 17:04 ` [PATCH 2/3] dt-bindings: iio: adc: Add GPADC for Allwinner H616 Chris Morgan
2024-04-17 22:49 ` Andre Przywara
2024-04-18 15:16 ` Rob Herring
2024-04-18 15:21 ` Chris Morgan
2024-04-18 15:17 ` Rob Herring
2024-04-20 10:10 ` Jonathan Cameron
2024-04-17 17:04 ` [PATCH 3/3] arm64: dts: allwinner: h616: Add GPADC device node Chris Morgan
2024-04-17 22:58 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f9d62c1-12f5-4d52-a511-602281857dbe@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).