* [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
@ 2022-12-23 7:33 Youghandhar Chintala
2022-12-23 7:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Youghandhar Chintala @ 2022-12-23 7:33 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, quic_mpubbise, devicetree, linux-kernel,
Youghandhar Chintala
Currently, the boot loader code used in the SC7280 SoC accesses
the WiFi node using node names (wifi@<addr>). Since the bootloader
is a common code that is used in SoCs having different WiFi chipsets,
it is better if the bootloader code accesses the WiFi node using
a WiFi alias. The advantage of this method is that the boot loader
code need not be changed for every new WiFi chip.
Therefore, add wifi alias entry for SC7280-idp device tree
Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
---
V2:
-Added purpose of this in the commit message
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index cd432a2856a7..c4f88d7b3758 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -18,6 +18,7 @@ / {
aliases {
bluetooth0 = &bluetooth;
serial1 = &uart7;
+ wifi0 = &wifi;
};
max98360a: audio-codec-0 {
--
2.38.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
2022-12-23 7:33 [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp Youghandhar Chintala
@ 2022-12-23 7:59 ` Krzysztof Kozlowski
2022-12-28 7:02 ` Youghandhar Chintala (Temp)
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-23 7:59 UTC (permalink / raw)
To: Youghandhar Chintala, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, quic_mpubbise, devicetree, linux-kernel
On 23/12/2022 08:33, Youghandhar Chintala wrote:
> Currently, the boot loader code used in the SC7280 SoC accesses
> the WiFi node using node names (wifi@<addr>). Since the bootloader
> is a common code that is used in SoCs having different WiFi chipsets,
> it is better if the bootloader code accesses the WiFi node using
> a WiFi alias. The advantage of this method is that the boot loader
> code need not be changed for every new WiFi chip.
> Therefore, add wifi alias entry for SC7280-idp device tree
Sounds good but which bootloader.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
2022-12-23 7:59 ` Krzysztof Kozlowski
@ 2022-12-28 7:02 ` Youghandhar Chintala (Temp)
2022-12-28 9:08 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Youghandhar Chintala (Temp) @ 2022-12-28 7:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, quic_mpubbise, devicetree, linux-kernel
On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>> Currently, the boot loader code used in the SC7280 SoC accesses
>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>> is a common code that is used in SoCs having different WiFi chipsets,
>> it is better if the bootloader code accesses the WiFi node using
>> a WiFi alias. The advantage of this method is that the boot loader
>> code need not be changed for every new WiFi chip.
>> Therefore, add wifi alias entry for SC7280-idp device tree
> Sounds good but which bootloader.
>
> Best regards,
> Krzysztof
Depth-charge Chrome OS bootloader.
Regards,
Youghandhar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
2022-12-28 7:02 ` Youghandhar Chintala (Temp)
@ 2022-12-28 9:08 ` Krzysztof Kozlowski
2022-12-28 9:43 ` Youghandhar Chintala (Temp)
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-28 9:08 UTC (permalink / raw)
To: Youghandhar Chintala (Temp), agross, andersson, konrad.dybcio,
robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, quic_mpubbise, devicetree, linux-kernel
On 28/12/2022 08:02, Youghandhar Chintala (Temp) wrote:
>
> On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
>> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>>> Currently, the boot loader code used in the SC7280 SoC accesses
>>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>>> is a common code that is used in SoCs having different WiFi chipsets,
>>> it is better if the bootloader code accesses the WiFi node using
>>> a WiFi alias. The advantage of this method is that the boot loader
>>> code need not be changed for every new WiFi chip.
>>> Therefore, add wifi alias entry for SC7280-idp device tree
>> Sounds good but which bootloader.
>>
>> Best regards,
>> Krzysztof
>
> Depth-charge Chrome OS bootloader.
Put it in the commit msg.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp
2022-12-28 9:08 ` Krzysztof Kozlowski
@ 2022-12-28 9:43 ` Youghandhar Chintala (Temp)
0 siblings, 0 replies; 5+ messages in thread
From: Youghandhar Chintala (Temp) @ 2022-12-28 9:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, quic_mpubbise, devicetree, linux-kernel
On 12/28/2022 2:38 PM, Krzysztof Kozlowski wrote:
> On 28/12/2022 08:02, Youghandhar Chintala (Temp) wrote:
>> On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
>>> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>>>> Currently, the boot loader code used in the SC7280 SoC accesses
>>>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>>>> is a common code that is used in SoCs having different WiFi chipsets,
>>>> it is better if the bootloader code accesses the WiFi node using
>>>> a WiFi alias. The advantage of this method is that the boot loader
>>>> code need not be changed for every new WiFi chip.
>>>> Therefore, add wifi alias entry for SC7280-idp device tree
>>> Sounds good but which bootloader.
>>>
>>> Best regards,
>>> Krzysztof
>> Depth-charge Chrome OS bootloader.
> Put it in the commit msg.
>
> Best regards,
> Krzysztof
Added it in v3 version of patch.
Regards,
Youghandhar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-28 9:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 7:33 [PATCH v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp Youghandhar Chintala
2022-12-23 7:59 ` Krzysztof Kozlowski
2022-12-28 7:02 ` Youghandhar Chintala (Temp)
2022-12-28 9:08 ` Krzysztof Kozlowski
2022-12-28 9:43 ` Youghandhar Chintala (Temp)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).