From: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: krzk+dt@kernel.org, robh@kernel.org, andersson@kernel.org,
mani@kernel.org, alim.akhtar@samsung.com, bvanassche@acm.org,
avri.altman@wdc.com, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller
Date: Tue, 14 Jul 2026 12:01:36 +0530 [thread overview]
Message-ID: <8fa9c1b4-9a42-4c46-9c44-520e79540819@oss.qualcomm.com> (raw)
In-Reply-To: <20260706-curious-festive-ringtail-dd8fe4@quoll>
On 7/6/2026 12:13 PM, Krzysztof Kozlowski wrote:
> On Wed, Jul 01, 2026 at 03:35:36AM +0530, Nitin Rawat wrote:
>> Document the UFS Controller on Maili SoC.
>>
>> Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
>> ---
>> Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> Why is MMIO address space size flexible here?
>
> A few previous Maili bindings had the same problem - your Claude vibe
> coding just looks at one piece and you do not review but trust that LLM.
>
> So again the same comments as other Maili bindings.
Thanks for catching this. Since Maili supports both MCQ and STD register
regions, I'll add 'qcom,maili-ufshc' in v2 to the allOf condition that
enforces minItems: 2 for reg and reg-names for MCQ targets.
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2026-07-14 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 22:05 [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller Nitin Rawat
2026-07-06 6:43 ` Krzysztof Kozlowski
2026-07-14 6:31 ` Nitin Rawat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fa9c1b4-9a42-4c46-9c44-520e79540819@oss.qualcomm.com \
--to=nitin.rawat@oss.qualcomm.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox