From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9490314882B for ; Thu, 27 Jun 2024 12:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719490480; cv=none; b=lPQk2F6fJme1R8MD89qtbcM3suE8fW3y07tH9MC8hBwHfnR+QT+gjoOd7tWBCloogQZOxSPB59es3gHrkI496+ER/KXcB7vxOO80tWOq36wU/tGB94noKjaH9uD86o/1JEuoEJetY5vLnsb/8Rx4rWWY2CE62kjAgS5Xof1NKYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719490480; c=relaxed/simple; bh=rhR58Z/6MO8Xb+vPZaG389xADtXgw42wxVv/5CC+S6E=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=WZeMzEOIDqXAczAS/onNL/F0QgGJvA+zq+aE2OJ+9M4fS73heuPLyaG4NRsHNQhyegSFu1c/dKyPMXsr73eBGXcPVmgxibwhsmgO0hSuF6HQFAMkbEE9O4RQQZqqfwL28jvmeWcqyxi2yqOOz/qrQ4uUUpI3LNsxnOQKAFqArCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=mfOu8w+U; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="mfOu8w+U" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45RB4xei013769; Thu, 27 Jun 2024 14:13:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= ha2cvNOTE07k+v+MQz0K2fm+9Ef07NW+kplxMiWcFGk=; b=mfOu8w+U37XZoNVO o+88UpQfCcxI5zkBs6JXtmzi9TXGQzOJV/tMFpe6JBM+sPWXNSks+VKdaPX3x8eL onT5F9qGd70YRdq0Bcdu8uPRhzKLtJ920y/EUC5D1GKwAhFh23LMeqpN9wFzwaMd QuukyhjPp1P1UuADkGGrBqefmlfo6sgWJWyCHnxXQxKkNsC0Tip1ebHcgoxT5qwr Mf/wbV/3P7hh77u/+aQfjuXTXeuZfigp4clwyFtkhVvHmK+26R98HSo3qAfdLUnJ fyIi3HucRtEXT/8lXty5GrHeiHG6XcWqcKI6aHhwlwHWQapHRKYMWoQJGmWtDQJk iHm8yw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3yx9jjjxd1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jun 2024 14:13:47 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 8A6734002D; Thu, 27 Jun 2024 14:13:43 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 8BB352194F1; Thu, 27 Jun 2024 14:13:05 +0200 (CEST) Received: from [10.48.86.79] (10.48.86.79) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 27 Jun 2024 14:13:04 +0200 Message-ID: <8fb70911-a278-43b3-bcaf-c88b43bddb73@foss.st.com> Date: Thu, 27 Jun 2024 14:13:04 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: stm32: Add phandle to nvmem efuse into STM32MP13xx ethernet DT node To: Marek Vasut , CC: Christophe Roullier , Conor Dooley , Krzysztof Kozlowski , Maxime Coquelin , Rob Herring , , , References: <20240623191602.67424-1-marex@denx.de> Content-Language: en-US From: Alexandre TORGUE In-Reply-To: <20240623191602.67424-1-marex@denx.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-27_06,2024-06-27_03,2024-05-17_01 Hi Marek On 6/23/24 21:15, Marek Vasut wrote: > The efuses on STM32MP13xx can be populated with ethernet MAC address. > Add the nvmem-cells/nvmem-cell-name DT properties to ethernet MAC DT > nodes to describe the placement of both MAC address fields within the > efuses, so the ethernet MAC driver can access the efuses and populate > the correct MAC address into the hardware. > > Signed-off-by: Marek Vasut > --- > Cc: Alexandre Torgue > Cc: Christophe Roullier > Cc: Conor Dooley > Cc: Krzysztof Kozlowski > Cc: Maxime Coquelin > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > --- > arch/arm/boot/dts/st/stm32mp131.dtsi | 2 ++ > arch/arm/boot/dts/st/stm32mp133.dtsi | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi > index f41508195eb51..55f4150524f3c 100644 > --- a/arch/arm/boot/dts/st/stm32mp131.dtsi > +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi > @@ -1528,6 +1528,8 @@ ethernet1: ethernet@5800a000 { > <&rcc ETH1RX>, > <&rcc ETH1STP>, > <&rcc ETH1CK_K>; > + nvmem-cell-names = "mac-address"; > + nvmem-cells = <ðernet_mac1_address>; It should not be defined in soc dtsi file but rather in board file. OTP are provisioned by the end customer not by ST. If you order a SoC to ST it will not be provisioned OTP MAC addr will be set to 0. Regards alex > snps,axi-config = <&stmmac_axi_config_1>; > snps,mixed-burst; > snps,pbl = <2>; > diff --git a/arch/arm/boot/dts/st/stm32mp133.dtsi b/arch/arm/boot/dts/st/stm32mp133.dtsi > index ae2fbc09e93b9..48b6ddb59badf 100644 > --- a/arch/arm/boot/dts/st/stm32mp133.dtsi > +++ b/arch/arm/boot/dts/st/stm32mp133.dtsi > @@ -85,6 +85,8 @@ ethernet2: ethernet@5800e000 { > <&rcc ETH2RX>, > <&rcc ETH2STP>, > <&rcc ETH2CK_K>; > + nvmem-cell-names = "mac-address"; > + nvmem-cells = <ðernet_mac2_address>; > snps,axi-config = <&stmmac_axi_config_2>; > snps,mixed-burst; > snps,pbl = <2>;