From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00435C433E3 for ; Wed, 19 Aug 2020 08:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C53522080C for ; Wed, 19 Aug 2020 08:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726919AbgHSIrC (ORCPT ); Wed, 19 Aug 2020 04:47:02 -0400 Received: from mga18.intel.com ([134.134.136.126]:7927 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgHSIrB (ORCPT ); Wed, 19 Aug 2020 04:47:01 -0400 IronPort-SDR: NtMXpUc5Du7joJk6kDh5/E8+2aiKmErhqybp4OZhRg34NiA7U1DroZer4hU/FEdatHkvfmmlvj 7Kv+PfyEsimQ== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="142702420" X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="142702420" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 01:47:00 -0700 IronPort-SDR: RYAH+K/pkHTPZiI8w1HkUJPP8dvjwEmvCVdfPCwcyoRY95UawtTuXLMCNTXXGBfBb6tWL/+oEQ RursUpawwOOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="497681371" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 19 Aug 2020 01:46:59 -0700 Received: from [10.213.152.90] (rtanwar-MOBL.gar.corp.intel.com [10.213.152.90]) by linux.intel.com (Postfix) with ESMTP id 9FF86580628; Wed, 19 Aug 2020 01:46:55 -0700 (PDT) Subject: Re: [PATCH v7 0/2] pwm: intel: Add PWM driver for a new SoC To: Andy Shevchenko Cc: Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-pwm@vger.kernel.org, Lee Jones , Thierry Reding , Philipp Zabel , Rob Herring , Linux Kernel Mailing List , devicetree , songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com References: <20200818083852.GC1891694@smile.fi.intel.com> <37f7526e-5a04-1d27-347c-772fe085771e@linux.intel.com> From: "Tanwar, Rahul" Message-ID: <8fba2174-9010-19f3-29bf-0a31219d3793@linux.intel.com> Date: Wed, 19 Aug 2020 16:46:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andy, On 19/8/2020 3:54 pm, Andy Shevchenko wrote: > On Wed, Aug 19, 2020 at 7:18 AM Tanwar, Rahul > wrote: >> >> Hi Andy, >> >> On 18/8/2020 4:38 pm, Andy Shevchenko wrote: >>> On Tue, Aug 18, 2020 at 01:48:59PM +0800, Rahul Tanwar wrote: >>>> Patch 1 adds dt binding document in YAML format. >>>> Patch 2 add PWM fan controller driver for LGM SoC. >>>> >>>> v7: >>>> - Address code quality related review concerns. >>>> - Rename fan related property to pwm-*. >>>> - Fix one make dt_binding_check reported error. >>> I guess it misses the answer why pwm-fan can't be integrated into the soup? >>> >> Can you please elaborate more? I could not understand your point clearly. > It's not mine, it's Uwe's. There is an hwmon module called pwm-fan. As > far as *I* understand this, it can be utilized to control fans via PWM > APIs. And Uwe asked you if you considered that and why you don't > integrated (coupled) it here. Thanks for clarification. I now understand what Rob, Uwe & you mean by pwm-fan. I will check in detail about it if we can integrate it with pwm-fan hwmon driver. Regards, Rahul