From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931D71114; Wed, 27 Nov 2024 08:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732696945; cv=none; b=FIqHCd6yY9eZXfqX9LupDnybZ910ILGYvFdLbl/e4P1qJO2MAFFwPWfMgEuwCV19jBTV8a5yLAMWwOCZHwEZNcNF2Zdr6340hrgROTfH1RzF3/ZrzQo+7IXu/fJtwRs2EaNEQopFIDE7ndbnBHkfkHPyafs1aiMI0vxh62iIaGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732696945; c=relaxed/simple; bh=1SruQ6equFJEJ3DDQvtA5uhMPF4SVyogTYV0u07VntU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bcyl6amtEsxnn3hIt/FamAd2DfANdmRsQ1bJcDGW9ECsZt076MvPTzsoQUMQmvdRp2qwKfOiTvSKJ60PwejeQJ0Til7/xJsYQSq8CoDkOHZdODwt10DjcQvjyqw8R84SSckCYRcPQDqbpOklb3cVhbh5Tg7J+cm+EpS+SiSS9Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=XerAHcE/; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XerAHcE/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1732696941; bh=1SruQ6equFJEJ3DDQvtA5uhMPF4SVyogTYV0u07VntU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XerAHcE/bSIaVT+gDx5+/EXDHU4d77hSNKsYcHdGjAyUawEmdllA2suX/9cM4ePtZ +cMuz99nwjOx2nUQl5hhrazHxLAPvVZZ0yhfYtDxWLe4RVqVglSgh2DyWYp2d5D71i NNhbWNfuUWtOz+xhx2B5W+zwblnPOee4AdFrzTTwZ75SAb3e2jKuCMn0I+YGOra6vm O11LKMWWkJ/6qMAo3cgUTP64fUemDdu/UGxStaO+Jgc/ZYZ4mkG8sr2Udll4NZqQ3e vOoSXnkwUPO51ZeUCkC9/B+PttGmc9e0tv2hkM7uBhrZb1v85/U/7gNyKvYmIMp4Ma 0g9Gn6jLlVYeQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 08DD017E1330; Wed, 27 Nov 2024 09:42:21 +0100 (CET) Message-ID: <8fec2c21-9d72-4a6b-9f00-01f2e6375831@collabora.com> Date: Wed, 27 Nov 2024 09:42:20 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "simona@ffwll.ch" , "kernel@collabora.com" , "tzimmermann@suse.de" , "mripard@kernel.org" , "p.zabel@pengutronix.de" , "maarten.lankhorst@linux.intel.com" , "conor+dt@kernel.org" , "robh@kernel.org" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" References: <20241120124512.134278-1-angelogioacchino.delregno@collabora.com> <20241120124512.134278-8-angelogioacchino.delregno@collabora.com> <133167aa2a3fab40547f5dc6602adf2c3d9e01e5.camel@mediatek.com> <4143b793-c5b1-4b6d-8547-26a9dc526957@collabora.com> <0711c097f724409941239696f5ab790b302d194a.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <0711c097f724409941239696f5ab790b302d194a.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 27/11/24 04:08, CK Hu (胡俊光) ha scritto: > On Tue, 2024-11-26 at 09:57 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until you have verified the sender or the content. >> >> >> Il 26/11/24 08:42, CK Hu (胡俊光) ha scritto: >>> Hi, Angelo: >>> >>> On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote: >>>> External email : Please do not click links or open attachments until you have verified the sender or the content. >>>> >>>> >>>> Add support for the newer HDMI-TX (Encoder) v2 and DDC v2 IPs >>>> found in MediaTek's MT8195, MT8188 SoC and their variants, and >>>> including support for display modes up to 4k60 and for HDMI >>>> Audio, as per the HDMI 2.0 spec. >>>> >>>> HDCP and CEC functionalities are also supported by this hardware, >>>> but are not included in this commit. >>> >>> Both MT8173 HDMI and MT8173 CEC has hot plug detection interrupt. >>> I don't know why but MT8173 choose CEC to detect hot plug. >>> >>> Does MT8195 CEC has hot plug detection interrupt? >>> If it has, may we align the hot plug detection flow with MT8173? >>> >> >> The CEC on MT8195 does have an hotplug detection interrupt, but that *must* be >> used exclusively for CEC for one important reason. >> >> While on MT8188 we only have the HDMI (TX) Encoder, MT8195 features both HDMI TX >> and HDMI RX and in the specific case of this SoCs, the CEC block is shared between >> the two controllers. >> >> If we use the CEC hotplug detection for HDMI-TX, we wouldn't be able to share the >> block with the HDMI-RX without hacks. >> >> This is why we need to use the HTPLG/PORD provided by the HDMI-TX block instead of >> the CEC one. > > OK, please add this information to commit message so that we know why not use CEC to detect hot plug. > Sure, I'll do that for v2. Cheers, Angelo > Regards, > CK > >> >>> This is not a strong suggestion because I don't know why MT8173 choose CEC to detect. >>> I just want more function to be common. >> >> Yeah, I got the point and I would've asked the same question, but for the reasons >> that I explained, that's unfortunately not possible :-) >> >> Cheers, >> Angelo >> >>> >>> Regards, >>> CK >>> >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> --- >>>> >> >> >>