* [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
@ 2023-04-04 20:42 Rob Herring
2023-04-05 11:28 ` Vladimir Oltean
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2023-04-04 20:42 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Christian Marangi
Cc: netdev, devicetree, linux-kernel, linux-arm-msm
The schema doesn't allow for a single (unaddressed) ethernet port node
nor does a single port switch make much sense. So if there's always
multiple child nodes, "#address-cells" and "#size-cells" should be
required.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/ethernet-switch.yaml | 4 ++++
Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
index a04f8ef744aa..2ceccce6cbd7 100644
--- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
@@ -40,6 +40,10 @@ patternProperties:
type: object
description: Ethernet switch ports
+ required:
+ - "#address-cells"
+ - "#size-cells"
+
oneOf:
- required:
- ports
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
index d7748dd33199..ad1ff9533697 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
@@ -53,7 +53,9 @@ examples:
reg = <0x10>;
ports {
- /* ... */
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* ... */
};
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
2023-04-04 20:42 [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required Rob Herring
@ 2023-04-05 11:28 ` Vladimir Oltean
2023-04-05 12:23 ` Florian Fainelli
2023-04-06 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2023-04-05 11:28 UTC (permalink / raw)
To: Rob Herring
Cc: Andrew Lunn, Florian Fainelli, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Christian Marangi, netdev,
devicetree, linux-kernel, linux-arm-msm
On Tue, Apr 04, 2023 at 03:42:13PM -0500, Rob Herring wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
2023-04-04 20:42 [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required Rob Herring
2023-04-05 11:28 ` Vladimir Oltean
@ 2023-04-05 12:23 ` Florian Fainelli
2023-04-06 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-04-05 12:23 UTC (permalink / raw)
To: Rob Herring, Andrew Lunn, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Christian Marangi
Cc: netdev, devicetree, linux-kernel, linux-arm-msm
On 4/4/2023 1:42 PM, Rob Herring wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
2023-04-04 20:42 [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required Rob Herring
2023-04-05 11:28 ` Vladimir Oltean
2023-04-05 12:23 ` Florian Fainelli
@ 2023-04-06 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-06 1:00 UTC (permalink / raw)
To: Rob Herring
Cc: andrew, f.fainelli, olteanv, davem, edumazet, kuba, pabeni,
krzysztof.kozlowski+dt, agross, andersson, konrad.dybcio,
ansuelsmth, netdev, devicetree, linux-kernel, linux-arm-msm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 4 Apr 2023 15:42:13 -0500 you wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
>
> [...]
Here is the summary with links:
- dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
https://git.kernel.org/netdev/net-next/c/c8f1f2e94675
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-06 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 20:42 [PATCH] dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required Rob Herring
2023-04-05 11:28 ` Vladimir Oltean
2023-04-05 12:23 ` Florian Fainelli
2023-04-06 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).