devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 04/14] clk: qcom: cpu-8996: fix the init clock rate
Date: Fri, 13 Jan 2023 15:12:17 +0100	[thread overview]
Message-ID: <8ffac2a3-bbdd-06f2-b13f-8858eb9b1383@linaro.org> (raw)
In-Reply-To: <20230113120544.59320-5-dmitry.baryshkov@linaro.org>



On 13.01.2023 13:05, Dmitry Baryshkov wrote:
> Current multiplier (60) results in CPU getting the rate which is
> unlisted in the CPU frequency tables (60 * 19.2 = 1152 MHz). This
> results in warnings from the cpufreq during startup.
> 
> Change PLL programming (l = 54) to init CPU clocks to start with the
> frequency of 54 * 19.2 = 1036.8 MHz which is supported by both power and
> performance clusters from all speed bins.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/clk/qcom/clk-cpu-8996.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> index ed8cb558e1aa..d51965fda56d 100644
> --- a/drivers/clk/qcom/clk-cpu-8996.c
> +++ b/drivers/clk/qcom/clk-cpu-8996.c
> @@ -102,7 +102,7 @@ static const u8 alt_pll_regs[PLL_OFF_MAX_REGS] = {
>  /* PLLs */
>  
>  static const struct alpha_pll_config hfpll_config = {
> -	.l = 60,
> +	.l = 54,
>  	.config_ctl_val = 0x200d4828,
>  	.config_ctl_hi_val = 0x006,
>  	.test_ctl_val = 0x1c000000,

  reply	other threads:[~2023-01-13 14:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 12:05 [PATCH v3 00/14] clk: qcom: cpu-8996: stability fixes Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 01/14] dt-bindings: clock: qcom,msm8996-apcc: add sys_apcs_aux clock Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 02/14] clk: qcom: clk-alpha-pll: program PLL_TEST/PLL_TEST_U if required Dmitry Baryshkov
2023-01-13 14:11   ` Konrad Dybcio
2023-01-13 12:05 ` [PATCH v3 03/14] clk: qcom: cpu-8996: correct PLL programming Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 04/14] clk: qcom: cpu-8996: fix the init clock rate Dmitry Baryshkov
2023-01-13 14:12   ` Konrad Dybcio [this message]
2023-01-13 12:05 ` [PATCH v3 05/14] clk: qcom: cpu-8996: support using GPLL0 as SMUX input Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 06/14] clk: qcom: cpu-8996: skip ACD init if the setup is valid Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 07/14] clk: qcom: cpu-8996: simplify the cpu_clk_notifier_cb Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 08/14] clk: qcom: cpu-8996: setup PLLs before registering clocks Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 09/14] clk: qcom: cpu-8996: move qcom_cpu_clk_msm8996_acd_init call Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 10/14] clk: qcom: cpu-8996: fix PLL configuration sequence Dmitry Baryshkov
2023-01-13 14:12   ` Konrad Dybcio
2023-01-13 12:05 ` [PATCH v3 11/14] clk: qcom: cpu-8996: fix ACD initialization Dmitry Baryshkov
2023-01-13 14:13   ` Konrad Dybcio
2023-01-13 12:05 ` [PATCH v3 12/14] clk: qcom: cpu-8996: fix PLL clock ops Dmitry Baryshkov
2023-01-13 14:13   ` Konrad Dybcio
2023-01-13 12:05 ` [PATCH v3 13/14] clk: qcom: cpu-8996: change setup sequence to follow vendor kernel Dmitry Baryshkov
2023-01-13 12:05 ` [PATCH v3 14/14] arm64: dts: qcom: msm8996: support using GPLL0 as kryocc input Dmitry Baryshkov
2023-01-19  4:53 ` (subset) [PATCH v3 00/14] clk: qcom: cpu-8996: stability fixes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ffac2a3-bbdd-06f2-b13f-8858eb9b1383@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).