* [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
@ 2023-08-10 13:28 Robert Marko
2023-08-10 17:56 ` Konrad Dybcio
2023-08-11 15:20 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Robert Marko @ 2023-08-10 13:28 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: luka.perkov, Robert Marko
Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
it seems that I somehow made a mistake of passing it instead of the fixed
XO clock.
Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
index 5492aeed14a5..450179fbed32 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
@@ -231,8 +231,7 @@ sdhci: mmc@7824900 {
interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "hc_irq", "pwr_irq";
bus-width = <8>;
- clocks = <&gcc GCC_SDCC1_AHB_CLK>, <&gcc GCC_SDCC1_APPS_CLK>,
- <&gcc GCC_DCD_XO_CLK>;
+ clocks = <&gcc GCC_SDCC1_AHB_CLK>, <&gcc GCC_SDCC1_APPS_CLK>, <&xo>;
clock-names = "iface", "core", "xo";
status = "disabled";
};
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-10 13:28 [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
@ 2023-08-10 17:56 ` Konrad Dybcio
2023-08-11 8:46 ` Robert Marko
2023-08-11 15:20 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-08-10 17:56 UTC (permalink / raw)
To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: luka.perkov
On 10.08.2023 15:28, Robert Marko wrote:
> Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> it seems that I somehow made a mistake of passing it instead of the fixed
> XO clock.
>
> Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Is this another IPQ without RPM?
If so, this patch looks good, but please take the liberty to make clocks
and clock-names one-per-line :)
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-10 17:56 ` Konrad Dybcio
@ 2023-08-11 8:46 ` Robert Marko
0 siblings, 0 replies; 5+ messages in thread
From: Robert Marko @ 2023-08-11 8:46 UTC (permalink / raw)
To: Konrad Dybcio
Cc: agross, andersson, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, luka.perkov
On Thu, Aug 10, 2023 at 7:56 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 10.08.2023 15:28, Robert Marko wrote:
> > Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> > it seems that I somehow made a mistake of passing it instead of the fixed
> > XO clock.
> >
> > Fixes: 04b3b72b5b8f ("ARM: dts: qcom: ipq4019: Add SDHCI controller node")
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> Is this another IPQ without RPM?
Yes, AFAIK there is no RPM on this one.
>
> If so, this patch looks good, but please take the liberty to make clocks
> and clock-names one-per-line :)
Will do in v2.
Regards,
Robert
>
> Konrad
--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-10 13:28 [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
2023-08-10 17:56 ` Konrad Dybcio
@ 2023-08-11 15:20 ` Bjorn Andersson
2023-08-11 15:22 ` Konrad Dybcio
1 sibling, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2023-08-11 15:20 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, Robert Marko
Cc: luka.perkov
On Thu, 10 Aug 2023 15:28:21 +0200, Robert Marko wrote:
> Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
> it seems that I somehow made a mistake of passing it instead of the fixed
> XO clock.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
commit: 43a0ce827528bdc7f4d38d48d13987db24a4e7b1
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
2023-08-11 15:20 ` Bjorn Andersson
@ 2023-08-11 15:22 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-08-11 15:22 UTC (permalink / raw)
To: Bjorn Andersson, agross, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel, Robert Marko
Cc: luka.perkov
On 11.08.2023 17:20, Bjorn Andersson wrote:
>
> On Thu, 10 Aug 2023 15:28:21 +0200, Robert Marko wrote:
>> Using GCC_DCD_XO_CLK as the XO clock for SDHCI controller is not correct,
>> it seems that I somehow made a mistake of passing it instead of the fixed
>> XO clock.
>>
>>
>
> Applied, thanks!
>
> [1/1] ARM: dts: qcom: ipq4019: correct SDHCI XO clock
> commit: 43a0ce827528bdc7f4d38d48d13987db24a4e7b1
Please pick the v2 instead
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-11 15:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 13:28 [PATCH] ARM: dts: qcom: ipq4019: correct SDHCI XO clock Robert Marko
2023-08-10 17:56 ` Konrad Dybcio
2023-08-11 8:46 ` Robert Marko
2023-08-11 15:20 ` Bjorn Andersson
2023-08-11 15:22 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).