From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C5AC433EF for ; Mon, 11 Jul 2022 11:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiGKLCy (ORCPT ); Mon, 11 Jul 2022 07:02:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbiGKLCc (ORCPT ); Mon, 11 Jul 2022 07:02:32 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 852C671BDD for ; Mon, 11 Jul 2022 03:07:57 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id d12so7833598lfq.12 for ; Mon, 11 Jul 2022 03:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=z0gWPzpnf+Fkqqtj9BV5xWECqcqhY1y27pcs8oB10pk=; b=USz9x/SbaDxxtjzvjpOXTqjIY7Mz9wUW+iryz/OKPMURFKzZRjviyzbB12zhJrtslY 6aSHB4/fWCPW83DzUcvU3/ueoVONNJDF7O0QvgmHtNJXrQcmdXl0HltHAtmNd4aAq//V +g11Z6ZRJGlJCc5iOOpu2RR9QafTi+rymGrPE4XhZDCpeQenMqeZHyTYbQyhzhKqLg2v DBITsYLlulyjx63sVrcPHmZpuzo89AINn3GNyS2GOWXYCKX3GNDNniFJ/v0U5ADeeJZ0 jWwCYFPpwpTjMAasLOSDjhmmPxkwAtpZ3q1XIcRyO2b9HDgO0gVhV0Oyek2oK+n1qSEM vIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z0gWPzpnf+Fkqqtj9BV5xWECqcqhY1y27pcs8oB10pk=; b=2ShmiC/1bANPwP4jutLN7iy5QYMeD+/WZDiILXzs28DBmC/QY4nHrQVbS97HlZ8TJJ lMg0FrRjrr70wyU3Zb8mcQ6ZSMz2gvK6Z8++GS8VofAf3lnegPkIalCfgtBB6FQ9MtTX h9Cbh0fEWULoUuHvMF/DAopy/+SnEIGOM5+5YxFx+bFgCZ9OqAttTyEA53tQx8doelzF Sp4kJgHfqVEUhy3uteUyvdaPwii95iMfiC+RYPmG0WWpde0cW+jYhS8Q5vEivYwyQyoA mXs3+fDB9aW2UaVPllUWfAmWuh/J7C6onMKp/6dABa9ZO7VVyJNbNFly2Uo/9P2+A1zX eLXQ== X-Gm-Message-State: AJIora8p41Zc7Lm6Uklk9hdvaK8yiuD32ZDzq3cP9JQfptHEqegEtl6S jIcc9y9/xNUsq/7v2Zq6L8ccUw== X-Google-Smtp-Source: AGRyM1sQ4qfv3Gvrp6kUtXMTCc4OAJoE7ATLT59r9LNAKRYX4a5MGu0ec17krDwhI+DPHVOyIzdq/Q== X-Received: by 2002:a05:6512:b23:b0:489:d24e:5abf with SMTP id w35-20020a0565120b2300b00489d24e5abfmr5358846lfu.636.1657534075775; Mon, 11 Jul 2022 03:07:55 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id q22-20020a05651232b600b0047255d21190sm1449353lfe.191.2022.07.11.03.07.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 03:07:55 -0700 (PDT) Message-ID: <9005c10b-01a6-b463-d150-1935e79f92eb@linaro.org> Date: Mon, 11 Jul 2022 13:07:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 00/10] Add PSR support for eDP Content-Language: en-GB To: Vinod Polimera , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, bjorn.andersson@linaro.org, quic_aravindh@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com References: <1657532880-12897-1-git-send-email-quic_vpolimer@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1657532880-12897-1-git-send-email-quic_vpolimer@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2022 12:47, Vinod Polimera wrote: > Changes in v2: > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > - Don't modify whitespaces. > - Set self refresh aware from atomic_check. > - Set self refresh aware only if psr is supported. > - Provide a stub for msm_dp_display_set_psr. > - Move dp functions to bridge code. > > Changes in v3: > - Change callback names to reflect atomic interfaces. > - Move bridge callback change to separate patch as suggested by Dmitry. > - Remove psr function declaration from msm_drv.h. > - Set self_refresh_aware flag only if psr is supported. > - Modify the variable names to simpler form. > - Define bit fields for PSR settings. > - Add comments explaining the steps to enter/exit psr. > - Change DRM_INFO to drm_dbg_db. > > Changes in v4: > - Move the get crtc functions to drm_atomic. > - Add atomic functions for DP bridge too. > - Add ternary operator to choose eDP or DP ops. > - Return true/false instead of 1/0. > - mode_valid missing in the eDP bridge ops. > - Move the functions to get crtc into drm_atomic.c. > - Fix compilation issues. > - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc. > - Check for crtc state enable while reserving resources. > > Changes in v5: > - Move the mode_valid changes into a different patch. > - Complete psr_op_comp only when isr is set. > - Move the DP atomic callback changes to a different patch. > - Get crtc from drm connector state crtc. > - Move to separate patch for check for crtc state enable while > reserving resources. > > Signed-off-by: Sankeerth Billakanti > Signed-off-by: Kalyan Thota > Signed-off-by: Vinod Polimera > > Vinod Polimera (10): > drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from connector > state instead of dpu_enc Generic comment: please use 'drm/msm/dpu:' prefix instead. > drm: add helper functions to retrieve old and new crtc > drm/msm/dp: use atomic callbacks for DP bridge ops > drm/msm/dp: Add basic PSR support for eDP > drm/msm/dp: use the eDP bridge ops to validate eDP modes > drm/bridge: use atomic enable/disable callbacks for panel bridge > drm/bridge: add psr support for panel bridge callbacks > drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder > functions > drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver > drm/msm/disp/dpu1: check for crtc enable rather than crtc active to > release shared resources > > drivers/gpu/drm/bridge/panel.c | 68 ++++++++-- > drivers/gpu/drm/drm_atomic.c | 60 +++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 55 +++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 -- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- > drivers/gpu/drm/msm/dp/dp_catalog.c | 81 ++++++++++++ > drivers/gpu/drm/msm/dp/dp_catalog.h | 4 + > drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 +++++++++++ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 + > drivers/gpu/drm/msm/dp/dp_display.c | 31 +++-- > drivers/gpu/drm/msm/dp/dp_display.h | 2 + > drivers/gpu/drm/msm/dp/dp_drm.c | 187 ++++++++++++++++++++++++++-- > drivers/gpu/drm/msm/dp/dp_drm.h | 9 +- > drivers/gpu/drm/msm/dp/dp_link.c | 36 ++++++ > drivers/gpu/drm/msm/dp/dp_panel.c | 22 ++++ > drivers/gpu/drm/msm/dp/dp_panel.h | 6 + > drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++ > include/drm/drm_atomic.h | 7 ++ > 19 files changed, 634 insertions(+), 64 deletions(-) > -- With best wishes Dmitry