Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x

[Heiko Stuebner <heiko@sntech.de>]

Hi,

Am Donnerstag, 20. Oktober 2022, 09:10:44 CEST schrieb ilmich:
> > Hi,
> 
> Hi Johan,
> 
> >
> > Compatible strings must SoC orientated.
> >
> > Something like:
> > compatible = "rockchip,rk3228-crypto", "rockchip,rk3288-crypto";
> >
> > This string must be add to YAML document:
> > https://lore.kernel.org/linux-rockchip/20220927075511.3147847-25-clabbe@baylibre.com/
> >
> > The status of that serie is unknown to me.
> > Not sure by who or when that is going to be merged.
> >
> > Johan
> 
> thanks for the feedback, this is my first kernel patch.

no worries, we'll get you through it :-)

> Maybe at this point it is worth trying to combine the two jobs !?
> Or do I still have to modify my patch asking only to add the string in
> the yaml !?

actually you want to go the following route:

(1) pick up
- https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
- https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
as a base to work on

(2) create a patch to add your compatible.
I _think_ after that, the compatible block should looks
something like:

  compatible:
    oneOf:
      - const: rockchip,rk3288-crypto
      - const: rockchip,rk3328-crypto
      - const: rockchip,rk3399-crypto
      - items:
          - const: rockchip,rk3228-crypto
          - const: rockchip,rk3288-crypto

to handle the new dual element compatible.
	make dt_binding_check
should tell you about a wrong format.

(3) modify your dts patch to use the two compatibles
(4) export patches by
	git format-patch -2 --cover-letter
and mention in the cover-letter the dependency on the
yaml conversion.


Heiko