From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Wang <wanghongliang@loongson.cn>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
loongarch@lists.linux.dev
Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties
Date: Thu, 26 Mar 2026 08:49:19 +0100 [thread overview]
Message-ID: <900dc1a4-66ab-411f-8a32-4c6cf339e8ec@kernel.org> (raw)
In-Reply-To: <0d7dfe5b-5e2d-4850-8922-16eb6bd9bcae@kernel.org>
On 26/03/2026 08:02, Krzysztof Kozlowski wrote:
> On 26/03/2026 03:12, Hongliang Wang wrote:
>> Hi Krzysztof,
>>
>> Consider the clock framework relies on the device tree, and can only be
>> used on
>> Loongson 2K platform with dts parameter mechanism, It cannot be used on
>> Loongson
>
> Don't top post or request read receipts.
>
>> 3A+7A platform with the acpi parameter mechanism.
>
> And this patch is for ACPI? Then we finish discussion here, because
> dt-bindings is not for ACPI.
>
>> The i2c-ls2x driver is compatible with both Loongson 2K and 3A+7A
>> platform, parse
>> the same parameters regardless of dts or acpi parameter passing, So
>> clock-input
>> and clock-div attributes are defined to describe input clock of i2c
>> controller and
>> divisor of input clock. It can be used on both 2K and 3A+7A platform.
>
> And you cannot use them in DTS.
I need to keep guessing what you want to achieve, because neither your
message nor commit text was explicit - if you need properties for ACPI
and you want to be sure that DTS does not have them, then you could
define them as "foo:false" with a comment why (you always explain WHY
you are doing things). We don't have such convention so far, but I think
it will be useful when Rob finishes the ABI checker.
*Otherwise* minimum would be a comment in the driver that these are not
allowed in DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-26 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 1:18 [PATCH v2 0/2] i2c: ls2x: Add clock- related properties and parsing Hongliang Wang
2026-03-25 1:18 ` [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties Hongliang Wang
2026-03-25 11:42 ` Krzysztof Kozlowski
2026-03-25 11:43 ` Krzysztof Kozlowski
2026-03-26 2:12 ` Hongliang Wang
2026-03-26 7:02 ` Krzysztof Kozlowski
2026-03-26 7:49 ` Krzysztof Kozlowski [this message]
2026-03-26 11:48 ` Hongliang Wang
2026-03-26 12:23 ` Krzysztof Kozlowski
2026-03-27 2:06 ` Hongliang Wang
2026-03-27 3:09 ` Hongliang Wang
2026-03-27 6:39 ` Krzysztof Kozlowski
2026-03-26 7:21 ` Andi Shyti
2026-03-27 2:08 ` Hongliang Wang
2026-03-25 1:18 ` [PATCH v1 2/2] i2c: ls2x: Add clock-input and clock-div properties parsing Hongliang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=900dc1a4-66ab-411f-8a32-4c6cf339e8ec@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox