From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: hwmon: pmbus: add ti tps25990 documentation
Date: Mon, 16 Sep 2024 10:45:32 +0200 [thread overview]
Message-ID: <9035e0e1-ea47-4f40-b0d1-38dc4d80acee@kernel.org> (raw)
In-Reply-To: <1jzfofsvmh.fsf@starbuckisacylon.baylibre.com>
On 10/09/2024 11:31, Jerome Brunet wrote:
>>> +
>>> + interrupts:
>>> + description: PMBUS SMB Alert Interrupt.
>>> + maxItems: 1
>>> +
>>> + regulators:
>>> + type: object
>>> + description:
>>> + list of regulators provided by this controller.
>>
>> You have just one regulator, so drop "regulators" node and use directly
>> vout here.
>
> Just took the example the other pmbus device and did the same for
> consistency.
>
> In that case, there other (possible) regulator called gpdac1 and gpdac2.
> I haven't even tried to implement the support for those.
Your binding should be complete. Does not matter whether you implemented
it in drivers or not.
>
> Since it would not break old DTs to add that later, I thought it would be OK
> to add them later. Should I add them now ?
This should be added now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-16 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 15:39 [PATCH 0/3] hwmon: pmbus: add tps25990 efuse support Jerome Brunet
2024-09-09 15:39 ` [PATCH 1/3] dt-bindings: hwmon: pmbus: add ti tps25990 documentation Jerome Brunet
2024-09-10 7:48 ` Krzysztof Kozlowski
2024-09-10 9:31 ` Jerome Brunet
2024-09-11 14:45 ` Rob Herring
2024-09-11 17:26 ` Jerome Brunet
2024-09-16 8:45 ` Krzysztof Kozlowski [this message]
2024-09-09 15:39 ` [PATCH 2/3] hwmon: (pmbus/core) add POWER_GOOD signal limits support Jerome Brunet
2024-09-09 18:16 ` Guenter Roeck
2024-09-10 6:43 ` Jerome Brunet
2024-09-10 14:37 ` Guenter Roeck
2024-09-10 15:00 ` Jerome Brunet
2024-09-10 16:22 ` Guenter Roeck
2024-09-09 15:39 ` [PATCH 3/3] hwmon: (pmbus/tps25990): add initial support Jerome Brunet
2024-09-09 22:52 ` Guenter Roeck
2024-09-10 9:07 ` Jerome Brunet
2024-09-10 17:07 ` Guenter Roeck
2024-09-11 9:37 ` Jerome Brunet
2024-09-10 8:08 ` kernel test robot
2024-09-10 10:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9035e0e1-ea47-4f40-b0d1-38dc4d80acee@kernel.org \
--to=krzk@kernel.org \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).