From: Krzysztof Kozlowski <krzk@kernel.org>
To: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Marko <robimarko@gmail.com>,
Guru Das Srinagesh <linux@gurudas.dev>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC
Date: Thu, 14 May 2026 17:53:12 +0200 [thread overview]
Message-ID: <903e383b-e7e3-4ab7-a2d0-77f95d25069e@kernel.org> (raw)
In-Reply-To: <1d7141d7-3440-4360-bed2-d690fb30a116@oss.qualcomm.com>
On 08/05/2026 08:24, Komal Bajaj wrote:
>>> then:
>>> required:
>>> @@ -165,6 +167,7 @@ allOf:
>>> - qcom,scm-msm8660
>>> - qcom,scm-msm8960
>>> - qcom,scm-qcm2290
>>> + - qcom,scm-shikra
>>> - qcom,scm-sm6375
>> This looks wrong or the diff hunks are confusing. Aren't you changing
>> one if:then: block for clocks and then second different one which
>> disallows clocks?
>>
>> dtbs_check on your DTS would tell you...
>
> The two hunks touch two separate allOf blocks:
>
> - Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
> - Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one
> clock named core
>
> Both hunks are intentional.
> Verified with dtbs_check — no complaints.
Yes, you are right.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-14 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 17:53 [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC Komal Bajaj
2026-05-04 11:03 ` Krzysztof Kozlowski
2026-05-08 6:24 ` Komal Bajaj
2026-05-14 15:53 ` Krzysztof Kozlowski [this message]
2026-05-14 15:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=903e383b-e7e3-4ab7-a2d0-77f95d25069e@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@gurudas.dev \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox