From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DB8C7EE22 for ; Wed, 10 May 2023 10:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236264AbjEJKFx (ORCPT ); Wed, 10 May 2023 06:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235484AbjEJKFw (ORCPT ); Wed, 10 May 2023 06:05:52 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32016EA2 for ; Wed, 10 May 2023 03:05:45 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-50c8d87c775so9118813a12.3 for ; Wed, 10 May 2023 03:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683713144; x=1686305144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9jKt286KS5/9lbpQtTUhslsELt909PREUjMgX9aHY/0=; b=ZJhtXTPDbi/qNTFrKEFjdK9wa0NbOmtBAiFmWdwJ4+yB3TAgtsXreIz9C46zJUANnG PtFcuzYgiVVMd4ddD1fo1k2dRnj9JFFmOtgOfXVAy4v9BSQv5lUtMKXXLslhQOyZc54H HMW6/35OjPJV0RtysX0CY14uDchv7N6IOyuVSZM4HEZB24p00Kb9MSyqp0ymQNdgJYf7 d/aS4vabah+cej+ReS8uFrUnZwVyNibT5Vk7bt6kTpMMi/aB2Ea4irCb+NoAGzYi+As+ YRsE9vFoTTExz5OfkBuqw0FBKBS4/QiHWOonL6z/eH9ClxZLFBvNjfepmzEuuL6LZfzm W77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683713144; x=1686305144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9jKt286KS5/9lbpQtTUhslsELt909PREUjMgX9aHY/0=; b=F49nqI4BVUgYhOvwcqUVWr5qP9irXYgIV5pdaS+fiPPXimvD29Ruv3A+F+tSOCFdER OIrDKruKy+4KjBr8smCPeDquiehHyZ4wFYlfCFOVAnqxVJWGsrhDakImnkByZNa8wX1A RCHtG3BAVnjEFPLK05IImXnzb5B6DRtnhljqtzHrfAZ5fHkwPGaxlGuyYP7Dq9FexAto WiXy+NzUlrbl7lFN9yruxwWh4qTi0yPY4j3+h6iKY6WI5JfOKTfeUesEDQuHfaKt7Jjj 5IMtKMj+t+s+gY7RRMJDBNkDYMb5sgRzoD56Igwqm0Ko2A72KPKs/HDpRCaf2IZDWfZB uwqw== X-Gm-Message-State: AC+VfDzGdEmCifcHgROV0ov7ufKarRbjpmWNZLTQUlqI5DNVIzT0FvAw p8G6EbZAtF+wPcAHGCvNh7qMAw== X-Google-Smtp-Source: ACHHUZ6SJaggu0T0c984P/D1GIbEYGJVgoI0k1sVocoNl6b/3/Uew6h6W3G9uDRyFOra5RgbUVd/5A== X-Received: by 2002:a50:fb92:0:b0:50b:d270:6b6f with SMTP id e18-20020a50fb92000000b0050bd2706b6fmr15433060edq.4.1683713144236; Wed, 10 May 2023 03:05:44 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c175:a0f9:6928:8c9d? ([2a02:810d:15c0:828:c175:a0f9:6928:8c9d]) by smtp.gmail.com with ESMTPSA id w17-20020aa7d291000000b0050c524253dasm1767577edq.20.2023.05.10.03.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 03:05:43 -0700 (PDT) Message-ID: <9040e9bb-a16c-0186-edba-da986350340c@linaro.org> Date: Wed, 10 May 2023 12:05:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable Content-Language: en-US To: Luca Weiss , Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230407-pm7250b-sid-v1-0-fc648478cc25@fairphone.com> <20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/05/2023 10:34, Luca Weiss wrote: > On Wed May 10, 2023 at 10:07 AM CEST, Dmitry Baryshkov wrote: >> On Wed, 10 May 2023 at 09:55, Krzysztof Kozlowski >> wrote: >>> >>> On 10/05/2023 08:47, Luca Weiss wrote: >>>> Hi Krzysztof, >>>> >>>> On Fri Apr 7, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: >>>>> On 07/04/2023 09:45, Luca Weiss wrote: >>>>>> Like other Qualcomm PMICs the PM7250B can be used on different addresses >>>>>> on the SPMI bus. Use similar defines like the PMK8350 to make this >>>>>> possible. >>>>>> >>>>>> Signed-off-by: Luca Weiss >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------- >>>>>> 1 file changed, 16 insertions(+), 7 deletions(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>>>> index daa6f1d30efa..eeb476edc79a 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>>>> @@ -7,6 +7,15 @@ >>>>>> #include >>>>>> #include >>>>>> >>>>>> +/* This PMIC can be configured to be at different SIDs */ >>>>>> +#ifndef PM7250B_SID >>>>>> + #define PM7250B_SID 2 >>>>> >>>>> Drop indentation, although anyway I am against this. Please don't bring >>>>> new patterns of this at least till we settle previous discussion. >>>>> >>>>> https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88fa683a9c75@linaro.org/ >>>> >>>> What's the outcome of the discussion? For this PMIC it's totally enough >>>> to have the SID configurable like in this patch, I don't think this PMIC >>>> will be included twice in a board - at least I'm not aware of such a >>>> configuration. >>> >>> We did not reach consensus and I still disagree with complex macros or >>> macros depending on order of inclusion. >> >> I still think we should find a way to parametrise PMIC dtsi, however I >> agree with Krzysztof that complex CPP is not a way to go. > > What about the macro already used in-tree and proposed with this patch? > I wouldn't say this is a "complex macro" since it's just a single number > being replaced in a few places. Are you talking about the macro to which I responded: "or macros depending on order of inclusion." or something else? Best regards, Krzysztof