From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Ziyang Huang <hzyitc@outlook.com>
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_gokulsri@quicinc.com,
quic_srichara@quicinc.com, quic_varada@quicinc.com,
robh+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: ipq5018: Correct uart1_pins pinconf
Date: Fri, 1 Sep 2023 15:31:41 +0100 [thread overview]
Message-ID: <90a3675c-2e30-35a5-85d9-3d1b895ab265@linaro.org> (raw)
In-Reply-To: <TYZPR01MB55565E0E55FAE550EAA53D3AC9E4A@TYZPR01MB5556.apcprd01.prod.exchangelabs.com>
On 01/09/2023 14:09, Ziyang Huang wrote:
>> Is this change something that should be expressed for a particular
>> board ?
>>
>
> Yes, this is device-special. Some boards use GPIO20 and 21 while others
> use GPIO28 and 29. But we have defined a wrong value here. At lease, it
> should be a correct demo. Or should I leave 2 configs here to let device
> choose?
https://gist.github.com/ptpt52/ae47eb7b86ce2911df06d067152f02ac
U-Boot 2016.01 (Jul 08 2021 - 07:14:42 +0000)
DRAM: smem ram ptable found: ver: 1 len: 4
256 MiB
TEST-
SPI_ADDR_LEN=3
SF: Detected XM25QU128C with page size 256 Bytes, erase size 4 KiB,
total 16 MiB
*** Warning - bad CRC, using default environment
In: serial@78AF000
Out: serial@78AF000
Err: serial@78AF000
So, we're saying the correct default console is blsp0_uart0 ?
https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/blob/5343739b4070bcec2fecd72f758c16adc31a3083/arch/arm/dts/ipq5018-mp03.3.dts
---
bod
prev parent reply other threads:[~2023-09-01 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 16:34 [PATCH v2] arm64: dts: ipq5018: Correct uart1_pins pinconf Ziyang Huang
2023-08-31 20:19 ` Bryan O'Donoghue
2023-09-01 12:39 ` Sricharan Ramabadhran
2023-09-01 13:09 ` Ziyang Huang
2023-09-01 14:31 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90a3675c-2e30-35a5-85d9-3d1b895ab265@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hzyitc@outlook.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).