From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43497CA9EC2 for ; Mon, 28 Oct 2019 12:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A324208C0 for ; Mon, 28 Oct 2019 12:40:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KztUAi13" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728199AbfJ1Mks (ORCPT ); Mon, 28 Oct 2019 08:40:48 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55188 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389150AbfJ1Mkr (ORCPT ); Mon, 28 Oct 2019 08:40:47 -0400 Received: by mail-wm1-f65.google.com with SMTP id g7so9282494wmk.4 for ; Mon, 28 Oct 2019 05:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w/WLt7O2taIP8YM7ktvX+R/TNl8ElnwnfMYK27iQOaI=; b=KztUAi13eLRxuTdBVRwh7Ha/+XqKvFTVZ7r97D5Dcn4OevqhKWCHl5VqQAcFcWPPz5 gRWtBZn7ZtZo9GqySCYa75GMSvfkr8pVj7Sk8XLmnzpCRgGU/6ldH1Ld9miosbcfymoL iSHcyrDdLOW1eiDY7QIRwDy8Qag4soGDfQcrvA7p0ieaAd913vRGJ76VUyt6U6LnKvyn HW7aPzXto6UBTxD06JYTFN/ESAsbHhAMhbmTN6gLC5bWShWAl57tdoTJAbP6YTDQi+BM cMb1ytfnw0y60iLw0aUCqagyLjzXkFyHlbsM53OeHqwDEFqS8PsziTYdhshNW9FtJ+q0 LTWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w/WLt7O2taIP8YM7ktvX+R/TNl8ElnwnfMYK27iQOaI=; b=bfq+qk3mwOvpkylys7iOsk1tECrNo36+qasnDLZpN+/3LPZ8w8HL+Gi8x/xIv+onFl BNZiJBqGvL7RrBKCaxCr6j9eZTT18ZQ+YlBUebJsWNFSLReKkE4dGUXis6iV1NUdoSF1 HTjNbx9U5d8T4KxEo+NAnFiVsBHmxYBQ0TXQhasW2Yv7ja8wwctgWthBfCShrmjkKl6y oB0FWLJfUYasaYJwP2XonND+esjAyeNoW168t8saHnNxUynvMwdfFfbaR0rEcrXVLnHj fsh64Bn+CgO2KYQ64tm7kKf+Iyk2f1qbM63tVY0ZWMRGUdTPvL9uk2q8gaJYh45ggCVl erWw== X-Gm-Message-State: APjAAAWmY00ePNPnBQBkX9B8lYW7pQh/aXNUEYWnjUXPukmnspiHi0cI CoIi51OYn22tZovPjDHy/ojgkA== X-Google-Smtp-Source: APXvYqz4DB4lyfpP+bmW/8XijGIPT2kMEoKr8hKJwSWGlqShrMTBlem3CgCZyJMPgD0oZI0xyNDi4Q== X-Received: by 2002:a05:600c:22c4:: with SMTP id 4mr5720906wmg.177.1572266444055; Mon, 28 Oct 2019 05:40:44 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id f204sm15333062wmf.32.2019.10.28.05.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Oct 2019 05:40:43 -0700 (PDT) Subject: Re: [PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec To: Rob Herring Cc: broonie@kernel.org, linus.walleij@linaro.org, lee.jones@linaro.org, vinod.koul@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, linux-gpio@vger.kernel.org References: <20191018001849.27205-1-srinivas.kandagatla@linaro.org> <20191018001849.27205-2-srinivas.kandagatla@linaro.org> <20191025204338.GA25892@bogus> From: Srinivas Kandagatla Message-ID: <90b2d83b-f2b2-3a5d-4deb-589f4b48b208@linaro.org> Date: Mon, 28 Oct 2019 12:40:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191025204338.GA25892@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks Rob for the review. On 25/10/2019 21:43, Rob Herring wrote: > On Fri, Oct 18, 2019 at 01:18:39AM +0100, Srinivas Kandagatla wrote: >> This patch adds bindings for wcd9340/wcd9341 audio codec which can >> support both SLIMbus and I2S/I2C interface. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> .../bindings/sound/qcom,wcd934x.yaml | 169 ++++++++++++++++++ >> 1 file changed, 169 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml >> new file mode 100644 >> index 000000000000..299d6b96c339 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml >> @@ -0,0 +1,169 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/qcom,wcd934x.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bindings for Qualcomm WCD9340/WCD9341 Audio Codec >> + >> +maintainers: >> + - Srinivas Kandagatla >> + >> +description: | >> + Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. >> + It has in-built Soundwire controller, pin controller, interrupt mux and >> + supports both I2S/I2C and SLIMbus audio interfaces. >> + >> +properties: >> + compatible: >> + const: slim217,250 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + reset-gpios: >> + description: GPIO spec for reset line to use >> + maxItems: 1 >> + >> + slim-ifc-dev: >> + description: SLIMBus Interface device phandle > > phandle or... > Its Phandle. something like this is okay? slim-ifc-dev: $ref: '/schemas/types.yaml#/definitions/phandle-array' description: SLIMBus Interface device phandle >> + maxItems: 1 > > array? > > Needs a type if a phandle. > >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: extclk >> + >> + vdd-buck-supply: >> + description: A reference to the 1.8V buck supply >> + >> + vdd-buck-sido-supply: >> + description: A reference to the 1.8V SIDO buck supply >> + >> + vdd-rx-supply: >> + description: A reference to the 1.8V rx supply >> + >> + vdd-tx-supply: >> + description: A reference to the 1.8V tx supply >> + >> + vdd-vbat-supply: >> + description: A reference to the vbat supply >> + >> + vdd-io-supply: >> + description: A reference to the 1.8V I/O supply >> + >> + vdd-micbias-supply: >> + description: A reference to the micbias supply >> + >> + qcom,micbias1-millivolt: > > The standard unit is '-microvolt' > >> + description: Voltage betwee 1800mv-2850mv for micbias1 output > > typo... > Yep, will fix this and also move to standard unit microvolt > Sounds like constraints. > >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 > > With standard units, you can drop the type. > >> + >> + qcom,micbias2-millivolt: >> + description: Voltage betwee 1800mv-2850mv for micbias2 output >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + >> + qcom,micbias3-millivolt: >> + description: Voltage betwee 1800mv-2850mv for micbias3 output >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + >> + qcom,micbias4-millivolt: >> + description: Voltage betwee 1800mv-2850mv for micbias4 output >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + >> + clock-output-names: >> + const: mclk >> + >> + clock-frequency: >> + description: Clock frequency of output clk in Hz >> + >> + interrupt-controller: true >> + >> + '#interrupt-cells': >> + const: 1 >> + >> + '#clock-cells': >> + const: 0 >> + >> + '#sound-dai-cells': >> + const: 1 >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 1 >> + >> +patternProperties: >> + "^.*@[0-9a-f]+$": >> + type: object >> + description: | >> + WCD934x subnode for each slave devices. Bindings of each subnodes >> + depends on the specific driver providing the functionality and >> + documented in there respective bindings. > > s/there/their/ will fix this in next version! thanks, srini