From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE96C83005 for ; Wed, 7 Jun 2023 07:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239334AbjFGHgL (ORCPT ); Wed, 7 Jun 2023 03:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239783AbjFGHfq (ORCPT ); Wed, 7 Jun 2023 03:35:46 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB0B19BA for ; Wed, 7 Jun 2023 00:35:19 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5149b63151aso835680a12.3 for ; Wed, 07 Jun 2023 00:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686123317; x=1688715317; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f4KpC3kANHIp+gXw3u0FsGTEqDyd3EDrrwXoz3cWUm0=; b=t+obXPMDQN1MkgBs04xAvkKs3YG9raiPc+ui76dx2ia7MPZX1SjNl60T9O8hS4FTh3 OYegOl6tA9JHkB414fj6GQOM9scxq30zRB+KdiDuZHZ4/vCXyduKPJSgws+bhQ0HlgUy deyxiCXXSLyAUQa1d+aafbF1R4MYYNHkLwb5JLf0/ZvgSUvdRobJVh4QL+jtvUN9ALFQ QcJ9WuwmVayVPuOR0jHqGNqM/NaqFvTGf26F+PJR08Fe2Z/+Dw09MuVPkb+yugvolS/x 2VC1ExuGXhVKhwEpyMe7e2wWIGHQBG+zcF9SNpe6S/ABqc7ONelCZiZNwBllgsadDYk9 DgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686123317; x=1688715317; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f4KpC3kANHIp+gXw3u0FsGTEqDyd3EDrrwXoz3cWUm0=; b=IefV/zGK8FTc3y9/PUtJhlXHbYHBqr76Fw+HfUUX2gzU3ct71IF6qlcEHjt1mA1Zia lay+FUDnf+w07RFCD0GbvZGo9lg+xLlg2NDQlDnz46HFPchP+2xokEB++4s8lkt+L4an sY2S2Dzgr85Rrm7atPIEOuAqkCGEWnQmvW27WQJ8aoVA9ex00HUyGDqVSWw43ZmA7xU3 v9R03aJ5yw02OyRr1BVUiMYL3aqUIJxkdAqX4iM3tteBhUDwonr+nYiMzEaoMUcECHwP wqyy7yuyAKS85WlyHmzCPzIHmBUD+1LGkswSEIkr0+piypjro3PEtfY0zj0i7tLcz1G0 5/Qw== X-Gm-Message-State: AC+VfDynP0zbEdYsr0p9BegFuS5Gg3jdebu7nTXw5knkqh+OIb3KGASm Tgc3dcQVes+c3XhhQVf4ovAmdw== X-Google-Smtp-Source: ACHHUZ68IVdrnvQr4lSsZZkQxmJ/rw69WI5dJ1WDGRM1Wh0rel9cAHT2zgNzc3jpFoVnSCSRadJZOw== X-Received: by 2002:a05:6402:1049:b0:514:56b4:35a7 with SMTP id e9-20020a056402104900b0051456b435a7mr4026918edu.36.1686123317550; Wed, 07 Jun 2023 00:35:17 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id b13-20020aa7d48d000000b0050e01a965a3sm5931414edr.5.2023.06.07.00.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 00:35:17 -0700 (PDT) Message-ID: <90b9fd0d-fded-0c7f-d58c-c35bf225f6f9@linaro.org> Date: Wed, 7 Jun 2023 09:35:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem Content-Language: en-US To: Keith Zhao , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Cc: David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Sumit Semwal , christian.koenig@amd.com, Bjorn Andersson , Heiko Stuebner , Shawn Guo , Jagan Teki , Chris Morgan , Jack Zhu , Shengyang Chen , Changhuang Liang References: <20230602074043.33872-1-keith.zhao@starfivetech.com> <20230602074043.33872-2-keith.zhao@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230602074043.33872-2-keith.zhao@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/06/2023 09:40, Keith Zhao wrote: > Add bindings for JH7110 display subsystem which > has a display controller verisilicon dc8200 > and an HDMI interface. > > Signed-off-by: Keith Zhao > --- > .../display/verisilicon/starfive-hdmi.yaml | 93 +++++++++++++++ > .../display/verisilicon/verisilicon-dc.yaml | 110 ++++++++++++++++++ > .../display/verisilicon/verisilicon-drm.yaml | 42 +++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > MAINTAINERS | 7 ++ > 5 files changed, 254 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/verisilicon/starfive-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/verisilicon/verisilicon-dc.yaml > create mode 100644 Documentation/devicetree/bindings/display/verisilicon/verisilicon-drm.yaml > > diff --git a/Documentation/devicetree/bindings/display/verisilicon/starfive-hdmi.yaml b/Documentation/devicetree/bindings/display/verisilicon/starfive-hdmi.yaml > new file mode 100644 > index 000000000000..c30b7954a355 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/verisilicon/starfive-hdmi.yaml Filename matching compatible. > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/verisilicon/starfive-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive HDMI transmiter > + > +description: > + The StarFive SoC uses the HDMI signal transmiter based on innosilicon IP > + to generate HDMI signal from its input and transmit the signal to the screen. > + > +maintainers: > + - Keith Zhao > + - ShengYang Chen > + > +properties: > + compatible: > + const: starfive,hdmi Conor already commented on this. > + > + reg: > + minItems: 1 > + > + interrupts: > + items: > + - description: The HDMI hot plug detection interrupt. > + > + clocks: > + items: > + - description: System clock of HDMI module. > + - description: Mclk clock of HDMI audio. > + - description: Bclk clock of HDMI audio. > + - description: Pixel clock generated by HDMI module. > + > + clock-names: > + items: > + - const: sysclk > + - const: mclk > + - const: bclk > + - const: pclk > + > + resets: > + items: > + - description: Reset for HDMI module. > + > + reset-names: > + items: > + - const: hdmi_tx > + > + '#sound-dai-cells': > + const: 0 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a display connector node. One port, so how do you get data? From where does it come? > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - '#sound-dai-cells' > + - port > + > +additionalProperties: false > + > +examples: > + - | > + hdmi: hdmi@29590000 { > + compatible = "starfive,hdmi"; > + reg = <0x29590000 0x4000>; > + interrupts = <99>; > + clocks = <&voutcrg 17>, > + <&voutcrg 15>, > + <&voutcrg 16>, > + <&hdmitx0_pixelclk>; > + clock-names = "sysclk", "mclk","bclk","pclk"; > + resets = <&voutcrg 9>; > + reset-names = "hdmi_tx"; > + #sound-dai-cells = <0>; > + hdmi_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + hdmi_input: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dc_out_dpi0>; Mixed up indentation. > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/display/verisilicon/verisilicon-dc.yaml b/Documentation/devicetree/bindings/display/verisilicon/verisilicon-dc.yaml > new file mode 100644 > index 000000000000..1322502c4cde > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/verisilicon/verisilicon-dc.yaml Same problem. > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/verisilicon/verisilicon-dc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive display controller > + > +description: > + The StarFive SoC uses the display controller based on Verisilicon IP > + to transfer the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Keith Zhao > + - ShengYang Chen > + > +properties: > + compatible: > + const: verisilicon,dc8200 > + > + reg: > + maxItems: 3 > + > + interrupts: > + items: > + - description: The interrupt will be generated when DC finish one frame > + > + clocks: > + items: > + - description: Clock for display system noc bus. > + - description: Pixel clock for display channel 0. > + - description: Pixel clock for display channel 1. > + - description: Clock for axi interface of display controller. > + - description: Core clock for display controller. > + - description: Clock for ahb interface of display controller. > + - description: External HDMI pixel clock. > + - description: Parent clock for pixel clock > + > + clock-names: > + items: > + - const: clk_vout_noc_disp Why do you need "clk_" prefixes? Drop. > + - const: clk_vout_pix0 > + - const: clk_vout_pix1 > + - const: clk_vout_axi > + - const: clk_vout_core > + - const: clk_vout_vout_ahb > + - const: hdmitx0_pixel > + - const: clk_vout_dc8200 > + > + resets: > + items: > + - description: Reset for axi interface of display controller. > + - description: Reset for ahb interface of display controller. > + - description: Core reset of display controller. > + > + reset-names: > + items: > + - const: rst_vout_axi Drop rst_ > + - const: rst_vout_ahb > + - const: rst_vout_core > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port node with one endpoint connected to a hdmi node. Oh really? But your HDMI does not allow it! Submit DTS user of all this so we can see it. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + dc8200: dc8200@29400000 { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "verisilicon,dc8200"; > + reg = <0x29400000 0x100>, > + <0x29400800 0x2000>, > + <0x295B0000 0x90>; Lowercase hex > + interrupts = <95>; > + clocks = <&syscrg 60>, > + <&voutcrg 7>, > + <&voutcrg 8>, > + <&voutcrg 4>, > + <&voutcrg 5>, > + <&voutcrg 6>, > + <&hdmitx0_pixelclk>, > + <&voutcrg 1>; > + clock-names = "clk_vout_noc_disp", "clk_vout_pix0", "clk_vout_pix1", "clk_vout_axi", > + "clk_vout_core", "clk_vout_vout_ahb", "hdmitx0_pixel","clk_vout_dc8200"; > + resets = <&voutcrg 0>, > + <&voutcrg 1>, > + <&voutcrg 2>; > + reset-names = "rst_vout_axi","rst_vout_ahb","rst_vout_core"; > + dc_out: port { > + #address-cells = <1>; > + #size-cells = <0>; > + dc_out_dpi0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&hdmi_input>; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/display/verisilicon/verisilicon-drm.yaml b/Documentation/devicetree/bindings/display/verisilicon/verisilicon-drm.yaml > new file mode 100644 > index 000000000000..aed8d4af2c55 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/verisilicon/verisilicon-drm.yaml Same comments > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/verisilicon/verisilicon-drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Verisilicon DRM master device What is DRM? If Linux thingy, then it does not suit bindings. Give it proper description of hardware. > + > +maintainers: > + - Keith Zhao > + - ShengYang Chen > + > +description: | Do not need '|' unless you need to preserve formatting. > + The Verisilicon DRM master device is a virtual device needed to list all We do not describe virtual devices in bindings. NAK. > + display controller or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: verisilicon,display-subsystem > + > + ports: > + $ref: /schemas/types.yaml#/definitions/phandle-array Ports is an object, not array. Drop entire property. It's just wrong. Best regards, Krzysztof