From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Eddie James <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: joel@jms.id.au, devicetree@vger.kernel.org,
linux-fsi@lists.ozlabs.org, robh@kernel.org,
conor+dt@kernel.org, krzk+dt@kernel.org, jk@ozlabs.org,
alistair@popple.id.au, lakshmiy@us.ibm.com
Subject: Re: [PATCH 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings
Date: Tue, 16 Apr 2024 09:36:33 +0930 [thread overview]
Message-ID: <90ced7e271213da481f7c0ec883d0189671563e8.camel@codeconstruct.com.au> (raw)
In-Reply-To: <0363badd-f5b0-42bd-bdd5-de6e7b5ee8c6@linux.ibm.com>
On Mon, 2024-04-15 at 09:59 -0500, Eddie James wrote:
> On 4/14/24 19:54, Andrew Jeffery wrote:
> > On Fri, 2024-04-12 at 09:43 -0500, Eddie James wrote:
> > > Set the new compatible string for Odyssey SBEFIFOs so that they
> > > don't collect async FFDC.
> > >
> > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > > ---
> > > .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 64 +++++++++----------
> > > .../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
> > > 2 files changed, 64 insertions(+), 64 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> > > index 214b2e6a4c6d..3a2bfdf035cb 100644
> > > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> > > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> > > @@ -2545,7 +2545,7 @@ scom500: scom@1000 {
> > > };
> > >
> > > sbefifo500: sbefifo@2400 {
> > > - compatible = "ibm,p9-sbefifo";
> > > + compatible = "ibm,ody-sbefifo";
> > > reg = <0x2400 0x400>;
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> >
> > Bit of a drive-by comment as I'm not really holding any stakes here,
> > but did the hardware actually change?
>
>
> Yes, the hardware did change in the Odyssey version.
Should there not be a new platform DTS then? Seems a bit puzzling, but
again this is a bit of a drive-by comment.
Andrew
next prev parent reply other threads:[~2024-04-16 0:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:43 [PATCH 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-12 14:43 ` [PATCH 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-13 7:47 ` Krzysztof Kozlowski
2024-04-15 0:50 ` Andrew Jeffery
2024-04-15 15:03 ` Eddie James
2024-04-12 14:43 ` [PATCH 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-12 14:43 ` [PATCH 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings Eddie James
2024-04-15 0:54 ` Andrew Jeffery
2024-04-15 14:59 ` Eddie James
2024-04-16 0:06 ` Andrew Jeffery [this message]
2024-04-16 14:48 ` Eddie James
2024-04-17 7:02 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ced7e271213da481f7c0ec883d0189671563e8.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=alistair@popple.id.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).