From: Florian Fainelli <f.fainelli@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rob Herring" <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Alvin Šipraga" <alsi@bang-olufsen.dk>
Subject: Re: [PATCH] ARM: dts: BCM5301X: Add DT for Asus RT-AC88U
Date: Fri, 24 Sep 2021 14:20:22 -0700 [thread overview]
Message-ID: <90eac7d8-c0b6-e8f2-a7b5-9c959b43e431@gmail.com> (raw)
In-Reply-To: <6b2aed0e-8c03-ce15-e33a-5d1d15d1b9a6@arinc9.com>
On 9/24/21 2:02 PM, Arınç ÜNAL wrote:
>> 0x200 is not the address of the Realtek switch on the MDIO bus, 0x200 is
>> the offset with mdio mux that needs to be toggled (bit 9). You still
>> need to provide the Ethernet switch's address on the MDIO bus which
>> appears to be 0.
>
> Oh, we flip the 9th bit. 2 to the power of 9 = 0x200. Got it!
>
> I tried 0 and 29 as the PHY ID. I'd assume the DSA realtek-smi driver
> would start probing the switch, however, nothing happens. Full log in
> attachments.
>
> [ 2.026772] bcm_iproc 18029200.spi: using bspi-mspi mode
> [ 2.033467] libphy: Fixed MDIO Bus: probed
> [ 2.038123] libphy: iProc MDIO bus: probed
> [ 2.042331] iproc-mdio 18003000.mdio: Broadcom iProc MDIO bus registered
> [ 2.049823] libphy: mdio_mux: probed
> [ 2.054206] libphy: mdio_mux: probed
> [ 2.058713] b53-srab-switch 18007000.ethernet-switch: found switch:
> BCM53012, rev 0
> [ 2.066671] bgmac_bcma: Broadcom 47xx GBit MAC driver loaded
>
> Quoting Documentation/devicetree/bindings/net/dsa/realtek-smi.txt for
> further reference.
>
>> Realtek SMI-based Switches
>> ==========================
>>
>> The SMI "Simple Management Interface" is a two-wire protocol using
>> bit-banged GPIO that while it reuses the MDIO lines MCK and MDIO does
>> not use the MDIO protocol. This binding defines how to specify the
>> SMI-based Realtek devices.
Ah this is the key here, using the MDIO controller won't work sorry
about misleading you. I suppose you will have to go back to the previous
Device Tree representation you had, but change the dsa,member property
and then you should be in business baring additional bugs/features.
--
Florian
next prev parent reply other threads:[~2021-09-24 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 12:19 [PATCH] ARM: dts: BCM5301X: Add DT for Asus RT-AC88U Arınç ÜNAL
2021-09-22 18:15 ` Florian Fainelli
2021-09-22 22:26 ` Arınç ÜNAL
2021-09-23 0:22 ` Florian Fainelli
2021-09-24 8:50 ` Arınç ÜNAL
2021-09-24 16:32 ` Florian Fainelli
2021-09-24 21:02 ` Arınç ÜNAL
2021-09-24 21:20 ` Florian Fainelli [this message]
2021-09-24 21:44 ` Arınç ÜNAL
2021-09-22 18:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90eac7d8-c0b6-e8f2-a7b5-9c959b43e431@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=arinc.unal@arinc9.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).