From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jakub Kicinski" <kuba@kernel.org>,
"Arthur Crépin Leblond" <arthur@marmottus.net>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] w5100: restore GPIO-based link detection
Date: Wed, 05 Aug 2026 09:56:29 +0200 [thread overview]
Message-ID: <910e82a4-24ca-451d-b9f8-5039cafea672@app.fastmail.com> (raw)
In-Reply-To: <20260804135807.0912ddf9@kernel.org>
On Tue, Aug 4, 2026, at 22:58, Jakub Kicinski wrote:
> On Tue, 04 Aug 2026 19:40:56 +0200 Arthur Crépin Leblond wrote:
>> Commit dacf281771a9 ("w5100: remove unused gpio link detection")
>
> Sounds like a fix, so the two patches should probably travel separately,
> the fix with a Fixes tag and more explanation (what you have in the
> cover letter and more) in the message.
>
> And the conversion should travel via net-next.
It's not really a fix for my patch though: the original code never
worked on mainline kernels because the w5100_spi_probe() function
always passed -EINVAL as the gpio number since it was first added in
630cf09751fe ("net: w5100: support SPI interface mode"). Arthur
correctly adds support for the link gpio line using DT probing.
I would suggest rewording the patch description to clarify this
by describing what the added code does first before mentioning
the removal of the old version.
Arnd
next prev parent reply other threads:[~2026-08-05 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 17:40 [PATCH v2 0/2] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-04 17:40 ` [PATCH v2 1/2] " Arthur Crépin Leblond
2026-08-04 18:44 ` Arnd Bergmann
2026-08-04 20:58 ` Jakub Kicinski
2026-08-05 7:56 ` Arnd Bergmann [this message]
2026-08-05 17:58 ` sashiko-bot
2026-08-04 17:40 ` [PATCH v2 2/2] dt-bindings: net: convert wiznet,w5x00 to YAML Arthur Crépin Leblond
2026-08-04 18:49 ` Rob Herring (Arm)
2026-08-05 11:08 ` Krzysztof Kozlowski
2026-08-05 17:23 ` Arthur Crépin Leblond
2026-08-05 17:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910e82a4-24ca-451d-b9f8-5039cafea672@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew+netdev@lunn.ch \
--cc=arthur@marmottus.net \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox