From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613B2C3A5A7 for ; Thu, 8 Dec 2022 10:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbiLHKCz (ORCPT ); Thu, 8 Dec 2022 05:02:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbiLHKCt (ORCPT ); Thu, 8 Dec 2022 05:02:49 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB255186D8; Thu, 8 Dec 2022 02:02:47 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id D29EB24DD6E; Thu, 8 Dec 2022 18:02:46 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 8 Dec 2022 18:02:47 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 8 Dec 2022 18:02:46 +0800 Message-ID: <91201e26-76b9-619e-99a0-b60f08981a8a@starfivetech.com> Date: Thu, 8 Dec 2022 18:02:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Jaehoon Chung , Ulf Hansson , References: <20221207131731.1291517-1-william.qiu@starfivetech.com> <20221207131731.1291517-2-william.qiu@starfivetech.com> From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/12/8 17:01, Krzysztof Kozlowski wrote: > On 08/12/2022 09:44, William Qiu wrote: >> >>>> + >>>> + clock-names: >>>> + minItems: 1 >>>> + items: >>>> + - const: biu >>>> + - const: ciu >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + starfive,sys-syscon: >>>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>>> + description: >>>> + The desired number of times that the host execute tuning when needed. >>> >>> That's not matching the property name. Missing number of items... this >>> is anyway confusing. Why number of tuning tries is a property of DT? >>> >> >> Will update the description. > > I propose first to explain what is it. Because it is not about > description only, but also type. Your driver uses this as syscon, so > this cannot be uint32-array but phandle-array... > > Best regards, > Krzysztof > Hi Krzysztof, Thank you for suggestion and I'll take it. I'll update it in next version. Best regards, William Qiu