devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Stephan Gerhold <stephan@gerhold.net>,
	Jonathan Cameron <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Robert Yang" <decatf@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025
Date: Tue, 11 May 2021 12:44:23 +0200	[thread overview]
Message-ID: <91258724-09cc-ed39-2277-6fbcca0c53e9@redhat.com> (raw)
In-Reply-To: <20210511095409.9290-1-stephan@gerhold.net>

Hi,

On 5/11/21 11:54 AM, Stephan Gerhold wrote:
> KX023-1025 [1] is another accelerometer from Kionix that has lots
> of additional functionality compared to KXCJK-1013. It combines the
> motion interrupt functionality from KXCJK with the tap detection
> from KXTF9, plus a lot more other functionality.
> 
> This patch set does not add support for any of the extra functionality,
> but makes basic functionality work with the existing kxcjk-1013 driver.
> 
> At first, the register map for the KX023-1025 seems quite different
> from the other accelerometers supported by the kxcjk-1013.
> However, it turns out that at least most of the register bits
> still mean the same for KX023-1025.
> 
> This patch set refactors the kxcjk-1013 driver a little bit
> to get the register addresses from a chip-specific struct.
> The register bits can be re-used for all the different chips.
> 
> The KX023-1025 is used in several smartphones from Huawei.
> I tested these changes on a Huawei Ascend G7, someone else reported
> they also work fine on the Huawei Honor 5X (codename "kiwi").
> 
> [1]: https://kionixfs.azureedge.net/en/datasheet/KX023-1025%20Specifications%20Rev%2012.0.pdf
> 
> Stephan Gerhold (3):
>   dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025
>   iio: accel: kxcjk-1013: Refactor configuration registers into struct
>   iio: accel: kxcjk-1013: Add support for KX023-1025

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans


  parent reply	other threads:[~2021-05-11 10:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  9:54 [PATCH 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025 Stephan Gerhold
2021-05-11  9:54 ` [PATCH 1/3] dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025 Stephan Gerhold
2021-05-11  9:54 ` [PATCH 2/3] iio: accel: kxcjk-1013: Refactor configuration registers into struct Stephan Gerhold
2021-05-11 12:37   ` kernel test robot
2021-05-11 12:37   ` [RFC PATCH] iio: accel: kxcjk-1013: kxcjk1013_regs can be static kernel test robot
2021-05-11  9:54 ` [PATCH 3/3] iio: accel: kxcjk-1013: Add support for KX023-1025 Stephan Gerhold
2021-05-11 13:14   ` kernel test robot
2021-05-11 13:14   ` [RFC PATCH] iio: accel: kxcjk-1013: kx0231025_regs can be static kernel test robot
2021-05-11 10:44 ` Hans de Goede [this message]
2021-05-11 14:10   ` [PATCH 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025 Jonathan Cameron
2021-05-11 14:28 ` Michał Mirosław
2021-05-11 14:38   ` Stephan Gerhold
2021-05-11 14:50     ` Michał Mirosław
2021-05-13 16:14       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91258724-09cc-ed39-2277-6fbcca0c53e9@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=decatf@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=stephan@gerhold.net \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).