* [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible
@ 2023-05-16 6:26 Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish-csot: " Jianhua Lu
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jianhua Lu @ 2023-05-16 6:26 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jianhua Lu
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
The bindings expect "novatek,nt36523" fallback in the panel compatible:
sm8250-xiaomi-elish-boe.dtb: panel@0: compatible: ['xiaomi,elish-boe-nt36523'] is too shor
Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
index 8b2ae39950ff..de6101ddebe7 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
@@ -13,6 +13,6 @@ / {
};
&display_panel {
- compatible = "xiaomi,elish-boe-nt36523";
+ compatible = "xiaomi,elish-boe-nt36523", "novatek,nt36523";
status = "okay";
};
--
2.39.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RESEND,PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish-csot: fix panel compatible
2023-05-16 6:26 [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Jianhua Lu
@ 2023-05-16 6:26 ` Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line Jianhua Lu
2023-05-16 7:01 ` [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Jianhua Lu @ 2023-05-16 6:26 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jianhua Lu
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
The bindings expect "novatek,nt36523" fallback in the panel compatible:
sm8250-xiaomi-elish-csot.dtb: panel@0: compatible: ['xiaomi,elish-csot-nt36523'] is too short
Fixes: 8a786036c7b6 ("arm64: dts: qcom: sm8250-xiaomi-elish-csot: Add Xiaomi Mi Pad 5 Pro CSOT variant")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
index a4d5341495cf..4cffe9c703df 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
@@ -13,6 +13,6 @@ / {
};
&display_panel {
- compatible = "xiaomi,elish-csot-nt36523";
+ compatible = "xiaomi,elish-csot-nt36523", "novatek,nt36523";
status = "okay";
};
--
2.39.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line
2023-05-16 6:26 [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish-csot: " Jianhua Lu
@ 2023-05-16 6:26 ` Jianhua Lu
2023-05-16 7:11 ` Krzysztof Kozlowski
2023-05-16 7:01 ` [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Krzysztof Kozlowski
2 siblings, 1 reply; 7+ messages in thread
From: Jianhua Lu @ 2023-05-16 6:26 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jianhua Lu
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
Remove a redundant empty line introduced by
commit 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
index 8af6a0120a50..eaac00085894 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
@@ -504,7 +504,6 @@ panel_in_1: endpoint {
remote-endpoint = <&dsi1_out>;
};
};
-
};
};
};
--
2.39.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible
2023-05-16 6:26 [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish-csot: " Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line Jianhua Lu
@ 2023-05-16 7:01 ` Krzysztof Kozlowski
2023-05-16 7:23 ` Jianhua Lu
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-16 7:01 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 16/05/2023 08:26, Jianhua Lu wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> The bindings expect "novatek,nt36523" fallback in the panel compatible:
>
> sm8250-xiaomi-elish-boe.dtb: panel@0: compatible: ['xiaomi,elish-boe-nt36523'] is too shor
>
> Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
I think there is no need to resend my patches. They are marked in
patchwork. Unless I am not responsive to something, please rather avoid
doing that.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line
2023-05-16 6:26 ` [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line Jianhua Lu
@ 2023-05-16 7:11 ` Krzysztof Kozlowski
2023-05-16 7:27 ` Jianhua Lu
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-16 7:11 UTC (permalink / raw)
To: Jianhua Lu, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 16/05/2023 08:26, Jianhua Lu wrote:
> Remove a redundant empty line introduced by
> commit 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
So you resent my patches just to add a comment? Not even as a dependency
of something? Please, no.
>
> Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
It's not a bug. Drop fixes tag.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible
2023-05-16 7:01 ` [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Krzysztof Kozlowski
@ 2023-05-16 7:23 ` Jianhua Lu
0 siblings, 0 replies; 7+ messages in thread
From: Jianhua Lu @ 2023-05-16 7:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, ~postmarketos/upstreaming, phone-devel
On Tue, May 16, 2023 at 09:01:35AM +0200, Krzysztof Kozlowski wrote:
> On 16/05/2023 08:26, Jianhua Lu wrote:
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > The bindings expect "novatek,nt36523" fallback in the panel compatible:
> >
> > sm8250-xiaomi-elish-boe.dtb: panel@0: compatible: ['xiaomi,elish-boe-nt36523'] is too shor
> >
> > Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
>
> I think there is no need to resend my patches. They are marked in
> patchwork. Unless I am not responsive to something, please rather avoid
> doing that.
Acked
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line
2023-05-16 7:11 ` Krzysztof Kozlowski
@ 2023-05-16 7:27 ` Jianhua Lu
0 siblings, 0 replies; 7+ messages in thread
From: Jianhua Lu @ 2023-05-16 7:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, ~postmarketos/upstreaming, phone-devel
On Tue, May 16, 2023 at 09:11:28AM +0200, Krzysztof Kozlowski wrote:
> On 16/05/2023 08:26, Jianhua Lu wrote:
> > Remove a redundant empty line introduced by
> > commit 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
>
> So you resent my patches just to add a comment? Not even as a dependency
> of something? Please, no.
Acked, I will split this patch to new series.
>
> >
> > Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
>
> It's not a bug. Drop fixes tag.
Acked
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-16 7:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 6:26 [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 2/3] arm64: dts: qcom: sm8250-xiaomi-elish-csot: " Jianhua Lu
2023-05-16 6:26 ` [RESEND,PATCH 3/3] arm64: dts: qcom: sm8250-xiaomi-elish: remove redundant empty line Jianhua Lu
2023-05-16 7:11 ` Krzysztof Kozlowski
2023-05-16 7:27 ` Jianhua Lu
2023-05-16 7:01 ` [RESEND,PATCH 1/3] arm64: dts: qcom: sm8250-xiaomi-elish-boe: fix panel compatible Krzysztof Kozlowski
2023-05-16 7:23 ` Jianhua Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).