[PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[Aleksander Jan Bajkowski]

Convert the Lantiq cpu temperature sensor bindings to yaml format.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
 .../bindings/hwmon/lantiq,cputemp.yaml        | 25 +++++++++++++++++++
 .../devicetree/bindings/hwmon/ltq-cputemp.txt | 10 --------
 2 files changed, 25 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lantiq,cputemp.yaml
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt

diff --git a/Documentation/devicetree/bindings/hwmon/lantiq,cputemp.yaml b/Documentation/devicetree/bindings/hwmon/lantiq,cputemp.yaml
new file mode 100644
index 000000000000..5dbe1c631a34
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lantiq,cputemp.yaml
@@ -0,0 +1,25 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Lantiq cpu temperature sensor
+
+maintainers:
+  - Florian Eckert <fe@dev.tdt.de>
+
+properties:
+  compatible:
+    const: lantiq,cputemp
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    cputemp {
+        compatible = "lantiq,cputemp";
+    };
diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
deleted file mode 100644
index 473b34c876dd..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-Lantiq cpu temperature sensor
-
-Requires node properties:
-- compatible value :
-	"lantiq,cputemp"
-
-Example:
-	cputemp@0 {
-		compatible = "lantiq,cputemp";
-	};
-- 
2.47.2

Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[Krzysztof Kozlowski]

On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
> +---
> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq cpu temperature sensor
> +
> +maintainers:
> +  - Florian Eckert <fe@dev.tdt.de>
> +
> +properties:
> +  compatible:
> +    const: lantiq,cputemp
> +
> +required:
> +  - compatible
> +

I think this reads and writs to some IOMEM space, so you really need
here 'reg'. That's the problem with such old bindings... binding is
broken, DTS is half-baked or non-existing, driver has 20 years.

BTW, why converting this old binding? Do you have any interest in
actually running MIPS?

I assume you did not check Rob's dt-convert branch to avoid
duplicated... because he did convert EXACTLY this binding. And more from
Lantiq.



Best regards,
Krzysztof

Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[Aleksander Jan Bajkowski]

Hi Krzysztof,

On 8/13/25 11:24, Krzysztof Kozlowski wrote:
> On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Lantiq cpu temperature sensor
>> +
>> +maintainers:
>> +  - Florian Eckert <fe@dev.tdt.de>
>> +
>> +properties:
>> +  compatible:
>> +    const: lantiq,cputemp
>> +
>> +required:
>> +  - compatible
>> +
> I think this reads and writs to some IOMEM space, so you really need
> here 'reg'. That's the problem with such old bindings... binding is
> broken, DTS is half-baked or non-existing, driver has 20 years.


These devices are not so old. They support multithreading. In the case
of NAT, they can process up to 700Mbps of traffic.


>
> BTW, why converting this old binding? Do you have any interest in
> actually running MIPS?


I have several devices with Lantiq SoC (xRX100, xRX200 and xRX330).
They are supported by OpenWRT. These are the only devices with mainline
Linux that support ADSL2+ and VDSL2. I would like to add the missing dts
files for the xRX200 and xRX330 families. I have started fixing the errors
reported by the dtbs_check script.

Downstream dts:
https://github.com/openwrt/openwrt/blob/main/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/vr9.dtsi#L29

>
> I assume you did not check Rob's dt-convert branch to avoid
> duplicated... because he did convert EXACTLY this binding. And more from
> Lantiq.


Thanks, I didn't know that.

>
>
>
> Best regards,
> Krzysztof

Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[Krzysztof Kozlowski]

On 13/08/2025 11:52, Aleksander Jan Bajkowski wrote:
> Hi Krzysztof,
> 
> On 8/13/25 11:24, Krzysztof Kozlowski wrote:
>> On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
>>> +---
>>> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Lantiq cpu temperature sensor
>>> +
>>> +maintainers:
>>> +  - Florian Eckert <fe@dev.tdt.de>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: lantiq,cputemp
>>> +
>>> +required:
>>> +  - compatible
>>> +
>> I think this reads and writs to some IOMEM space, so you really need
>> here 'reg'. That's the problem with such old bindings... binding is


Please address this. Driver on first glance tells me it accesses MMIO.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

[Krzysztof Kozlowski]

On 14/08/2025 00:21, Aleksander Jan Bajkowski wrote:
>          };
> 
>          cputemp@103040 {
>              compatible = "lantiq,cputemp";
>              reg = <0x103040 0x4>;
>          };
> ...
> 
> Best regards, Aleksander Jan Bajkowski
> 

Yes

Best regards,
Krzysztof